From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: Alex Deucher <alexdeucher@gmail.com>, amd-gfx@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [PATCH 1/3] drm/amdgpu/display: set gpu vm flag for all asics which support it
Date: Thu, 9 Jan 2020 11:23:28 +0100 [thread overview]
Message-ID: <be75d123-7f91-2bc1-fdc5-6faeadfef400@gmail.com> (raw)
In-Reply-To: <20200108224910.289731-1-alexander.deucher@amd.com>
Am 08.01.20 um 23:49 schrieb Alex Deucher:
> It won't get used unless the driver allows the gtt domain for
> display buffers which is controlled elsewhere.
>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Acked-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 1123f9ce86ee..fdf4d202ea1f 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -906,13 +906,15 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
>
> init_data.dce_environment = DCE_ENV_PRODUCTION_DRV;
>
> - /*
> - * TODO debug why this doesn't work on Raven
> - */
> - if (adev->flags & AMD_IS_APU &&
> - adev->asic_type >= CHIP_CARRIZO &&
> - adev->asic_type < CHIP_RAVEN)
> + switch (adev->asic_type) {
> + case CHIP_CARRIZO:
> + case CHIP_STONEY:
> + case CHIP_RAVEN:
> init_data.flags.gpu_vm_support = true;
> + break;
> + default:
> + break;
> + }
>
> if (amdgpu_dc_feature_mask & DC_FBC_MASK)
> init_data.flags.fbc_support = true;
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
prev parent reply other threads:[~2020-01-09 10:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 22:49 [PATCH 1/3] drm/amdgpu/display: set gpu vm flag for all asics which support it Alex Deucher
2020-01-08 22:49 ` [PATCH 2/3] drm/amdgpu: enable S/G display on PCO and RV2 (v2) Alex Deucher
2020-01-08 22:49 ` [PATCH 3/3] drm/amdgpu/display: set gpu vm flag for renoir Alex Deucher
2020-01-08 22:55 ` Harry Wentland
2020-01-09 5:36 ` [PATCH 1/3] drm/amdgpu/display: set gpu vm flag for all asics which support it Huang Rui
2020-01-09 20:19 ` Alex Deucher
2020-01-09 10:23 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be75d123-7f91-2bc1-fdc5-6faeadfef400@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.