Re: [PATCH mptcp-net 0/2] selftests: mptcp: connect: fix C23 extension warning

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 03/08/2025 16:08, Geliang Tang wrote:
> Hi Matt,
> 
> On Sun, 2025-08-03 at 14:13 +0200, Matthieu Baerts (NGI0) wrote:
>> GCC was complaining about the new label:
>>
>>   mptcp_connect.c:187:2: warning: label followed by a declaration is
>> a C23 extension [-Wc23-extensions]
>>     187 |         int err = getaddrinfo(node, service, hints, res);
>>         |         ^
>>
>>   mptcp_inq.c:79:2: warning: label followed by a declaration is a C23
>> extension [-Wc23-extensions]
>>      79 |         int err = getaddrinfo(node, service, hints, res);
>>         |         ^
>>
>>   mptcp_sockopt.c:166:2: warning: label followed by a declaration is
>> a C23 extension [-Wc23-extensions]
>>     166 |         int err = getaddrinfo(node, service, hints, res);
>>         |         ^
>>
>> Simply declare 'err' before the label to avoid this warning.
>>
>> Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
> 
> LGTM!
> 
> Reviewed-by: Geliang Tang <geliang@kernel.org>

Thank you for the review!

Now in our tree:

New patches for t/upstream-net and t/upstream:
- 9486cb4888a5: selftests: mptcp: connect: fix C23 extension warning
- 6a17fdde8884: selftests: mptcp: sockopt: fix C23 extension warning
- Results: 9380c91e86eb..82cf743daa3e (export-net)
- Results: c6e4c6478b19..58528cde3023 (export)

Tests are now in progress:

- export-net:
https://github.com/multipath-tcp/mptcp_net-next/commit/3ce0a4201191ee78fa4fbc3bcbe199f4409aa9ce/checks
- export:
https://github.com/multipath-tcp/mptcp_net-next/commit/673139156ef681c8c71abad4cd97db0ee2f7f6d0/checks

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.