Re: [igt-dev] [PATCH i-g-t v2 2/3] i915/gem_engine_topology: Add compute class

[Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>]

On 16/11/2021 16:44, Dixit, Ashutosh wrote:
> On Tue, 16 Nov 2021 02:19:21 -0800, Tvrtko Ursulin wrote:
>>>> diff --git a/lib/i915/gem_engine_topology.c b/lib/i915/gem_engine_topology.c
>>>> index 4e497a5c..729f42b0 100644
>>>> --- a/lib/i915/gem_engine_topology.c
>>>> +++ b/lib/i915/gem_engine_topology.c
>>>> @@ -130,6 +130,7 @@ static const char *class_names[] = {
>>>> 	[I915_ENGINE_CLASS_COPY]	  = "bcs",
>>>> 	[I915_ENGINE_CLASS_VIDEO]	  = "vcs",
>>>> 	[I915_ENGINE_CLASS_VIDEO_ENHANCE] = "vecs",
>>>> +	[I915_ENGINE_CLASS_COMPUTE]       = "ccs",
>>
>> When are the i915 patches planned to appear?
>>
>> Asking since there are user requests to add compute engine support to
>> intel_gpu_top and I am a bit unsure of the plans, given no platform
>> currently exports the engine but IGT code apparently went in.
> 
> I understand CCS patches have been posted but are now blocked on adequate
> IGT test coverage. Maybe it's ok to add CCS support to IGT intel_gpu_top
> first as long as we are using the engine query (CCS is absent from legacy
> engines) since the kernel will not return CCS?

It could be added but there is little point if it can never show 
anything. It can just wait I think until whatever platform first enables 
those engines.

It is just unusual that IGT has uapi which kernel knows nothing about.

Regards,

Tvrtko