All of lore.kernel.org
 help / color / mirror / Atom feed
From: JustinLai0215 <justinlai0215@realtek.com>
To: Paolo Abeni <pabeni@redhat.com>, "kuba@kernel.org" <kuba@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"andrew@lunn.ch" <andrew@lunn.ch>,
	Ping-Ke Shih <pkshih@realtek.com>,
	Larry Chiu <larry.chiu@realtek.com>
Subject: RE: [PATCH net-next v14 08/13] rtase: Implement net_device_ops
Date: Thu, 14 Dec 2023 12:47:49 +0000	[thread overview]
Message-ID: <be8a2a6a965f4dfca61febdaff556e63@realtek.com> (raw)
In-Reply-To: <955d390c57a93406d40985fbd1856bd1c500d75c.camel@redhat.com>

> 
> On Fri, 2023-12-08 at 17:47 +0800, Justin Lai wrote:
> > +static netdev_features_t rtase_fix_features(struct net_device *dev,
> > +                                         netdev_features_t
> features)
> > +{
> > +     netdev_features_t features_fix = features;
> > +
> > +     if (dev->mtu > MSS_MAX)
> > +             features_fix &= ~NETIF_F_ALL_TSO;
> > +
> > +     if (dev->mtu > ETH_DATA_LEN)
> > +             features_fix &= ~NETIF_F_ALL_TSO;
> 
> This latter condition is strictly more restrictive than the previous one, you can
> drop the latter. Also could you please drop a note about the why of it?

We don't support TSO for jumbo frames, so I will remove the MSS_MAX part.
> 
> Cheers,
> 
> Paolo


  reply	other threads:[~2023-12-14 12:48 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-08  9:47 [PATCH net-next v14 00/13] Add Realtek automotive PCIe driver Justin Lai
2023-12-08  9:47 ` [PATCH net-next v14 01/13] rtase: Add pci table supported in this module Justin Lai
2023-12-12  9:36   ` Paolo Abeni
2023-12-12 16:05     ` Jakub Kicinski
2023-12-14 12:42     ` JustinLai0215
2023-12-08  9:47 ` [PATCH net-next v14 02/13] rtase: Implement the .ndo_open function Justin Lai
2023-12-12  9:49   ` Paolo Abeni
2023-12-14 12:44     ` JustinLai0215
2023-12-08  9:47 ` [PATCH net-next v14 03/13] rtase: Implement the rtase_down function Justin Lai
2023-12-12 19:27   ` Jakub Kicinski
2023-12-14 12:54     ` JustinLai0215
2023-12-08  9:47 ` [PATCH net-next v14 04/13] rtase: Implement the interrupt routine and rtase_poll Justin Lai
2023-12-08  9:47 ` [PATCH net-next v14 05/13] rtase: Implement hardware configuration function Justin Lai
2023-12-08  9:47 ` [PATCH net-next v14 06/13] rtase: Implement .ndo_start_xmit function Justin Lai
2023-12-12 19:32   ` Jakub Kicinski
2023-12-14 13:00     ` JustinLai0215
2023-12-14 17:24       ` Jakub Kicinski
2023-12-18 10:27     ` Justin Lai
2023-12-08  9:47 ` [PATCH net-next v14 07/13] rtase: Implement a function to receive packets Justin Lai
2023-12-12 10:04   ` Paolo Abeni
2023-12-14 12:45     ` JustinLai0215
2023-12-18 10:18     ` Justin Lai
2023-12-08  9:47 ` [PATCH net-next v14 08/13] rtase: Implement net_device_ops Justin Lai
2023-12-12 10:09   ` Paolo Abeni
2023-12-14 12:47     ` JustinLai0215 [this message]
2023-12-08  9:47 ` [PATCH net-next v14 09/13] rtase: Implement pci_driver suspend and resume function Justin Lai
2023-12-12 19:19   ` Jakub Kicinski
2023-12-14 12:48     ` JustinLai0215
2023-12-08  9:47 ` [PATCH net-next v14 10/13] rtase: Implement ethtool function Justin Lai
2023-12-12 19:21   ` Jakub Kicinski
2023-12-08  9:47 ` [PATCH net-next v14 11/13] rtase: Add a Makefile in the rtase folder Justin Lai
2023-12-08  9:47 ` [PATCH net-next v14 12/13] realtek: Update the Makefile and Kconfig in the realtek folder Justin Lai
2023-12-08  9:47 ` [PATCH net-next v14 13/13] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai
2023-12-12 19:22   ` Jakub Kicinski
2023-12-14 12:51     ` JustinLai0215
2023-12-14 17:27       ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=be8a2a6a965f4dfca61febdaff556e63@realtek.com \
    --to=justinlai0215@realtek.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=larry.chiu@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.