Re: [PATCH v3 1/3] pps: clients: gpio: propagate probe error codes

[Rodolfo Giometti <giometti@enneenne.com>]

On Thu, Sep 17, 2026 at 07:56:09AM +0000, Eliav Farber wrote:
> Return the actual error code from both paths, and add the errno to the
> request_threaded_irq() failure message.
>
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
> diff --git a/drivers/pps/clients/pps-gpio.c b/drivers/pps/clients/pps-gpio.c
> index 73ec2c7335e5..038c55c5f7d4 100644
> --- a/drivers/pps/clients/pps-gpio.c
> +++ b/drivers/pps/clients/pps-gpio.c
> @@ -165,7 +165,7 @@ static int pps_gpio_probe(struct platform_device *pdev)
>  	ret = gpiod_to_irq(data->gpio_pin);
>  	if (ret < 0) {
>  		dev_err(dev, "failed to map GPIO to IRQ: %d\n", ret);
> -		return -EINVAL;
> +		return ret;
>  	}
>  	data->irq = ret;
>
> @@ -197,8 +197,8 @@ static int pps_gpio_probe(struct platform_device *pdev)
>  			  data->info.name, data);
>  	if (ret) {
>  		pps_unregister_source(data->pps);
> -		dev_err(dev, "failed to acquire IRQ %d\n", data->irq);
> -		return -EINVAL;
> +		dev_err(dev, "failed to acquire IRQ %d: %d\n", data->irq, ret);
> +		return ret;
>  	}
>
>  	dev_dbg(&data->pps->dev, "Registered IRQ %d as PPS source\n",

Looks good to me.

Since this restores the -EPROBE_DEFER that gpiod_to_irq() can return,
which the hardcoded -EINVAL was turning into a permanent probe failure,
it is probably worth adding:

   Fixes: 4461d65176b4 ("pps: descriptor-based gpio")

Ciao,

Rodolfo