From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43EE2C2BA83 for ; Fri, 14 Feb 2020 18:33:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB9222086A for ; Fri, 14 Feb 2020 18:33:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="taFxf6gi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB9222086A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:References:To:Subject:From:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dct+C9Po+Ys65TN2zJ5efiuVJnHkUoLnPhTqF0uu4QU=; b=taFxf6gihAxaWK iWEdxnSFAc6oMbMLA6HO+UdYKLzJG2rEbYhXl3/Ntr1CQWt9lwkXoFfmxf+pOlRNAYEc0ZTk4ejZ7 +06ht0FTX/+K4hFyInbMh1mr/FUbXdPP9iVJv3Jq8JVo81r0N3NjBN8qItBQjlPUENTH2VGtsxPiF UhcaOxvlCzVS4Bwjx3AXU7TYs2D8+85bAgqHcXtQF2c306SlEYn+GB3BW0A9JS5rkweDQ6ZS0T3IV f4kg1n58s7tmLFhzVtPweZXVnQuEOI5vewGUovB+rVZTdcAFSVIeMEWxMEsll0Sp0gYz5HS0ple9j SzaKRGM4w2j/DxNeqfSQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2fm1-0002qA-HG; Fri, 14 Feb 2020 18:33:09 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j2fls-0002ZN-3d for linux-arm-kernel@lists.infradead.org; Fri, 14 Feb 2020 18:33:01 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D83D101E; Fri, 14 Feb 2020 10:32:59 -0800 (PST) Received: from [10.1.196.105] (eglon.cambridge.arm.com [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D9BB3F68E; Fri, 14 Feb 2020 10:32:58 -0800 (PST) From: James Morse Subject: Re: [V2 2/3] firmware: arm_sdei: Removed multiple white lines. To: luanshi References: <1579145331-78633-1-git-send-email-zhangliguang@linux.alibaba.com> <1579145331-78633-2-git-send-email-zhangliguang@linux.alibaba.com> Message-ID: Date: Fri, 14 Feb 2020 18:32:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1579145331-78633-2-git-send-email-zhangliguang@linux.alibaba.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200214_103300_224047_C845A7F3 X-CRM114-Status: GOOD ( 14.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Luanshi, On 16/01/2020 03:28, luanshi wrote: > Remove one unnecessary white line. > > Signed-off-by: Liguang Zhang > --- > drivers/firmware/arm_sdei.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c > index 37e9bf0..f81c09e 100644 > --- a/drivers/firmware/arm_sdei.c > +++ b/drivers/firmware/arm_sdei.c > @@ -599,7 +599,6 @@ static int _sdei_event_register(struct sdei_event *event) > event->registered, > SDEI_EVENT_REGISTER_RM_ANY, 0); > > - > err = sdei_do_cross_call(_local_event_register, event); > if (err) { > spin_lock(&event->sdei_event_lock); I'm afraid these whitespace-only patches aren't worth sending. If its not caught at review, it gets to annoy the reader until someone can do a drive-by fix when they are changing adjacent code. I've merged this with the first patch in the eventual series. Thanks, James _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B246C2BA83 for ; Fri, 14 Feb 2020 18:33:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 29289222C2 for ; Fri, 14 Feb 2020 18:33:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730233AbgBNSdB (ORCPT ); Fri, 14 Feb 2020 13:33:01 -0500 Received: from foss.arm.com ([217.140.110.172]:43572 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729448AbgBNSc7 (ORCPT ); Fri, 14 Feb 2020 13:32:59 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D83D101E; Fri, 14 Feb 2020 10:32:59 -0800 (PST) Received: from [10.1.196.105] (eglon.cambridge.arm.com [10.1.196.105]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9D9BB3F68E; Fri, 14 Feb 2020 10:32:58 -0800 (PST) From: James Morse Subject: Re: [V2 2/3] firmware: arm_sdei: Removed multiple white lines. To: luanshi Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <1579145331-78633-1-git-send-email-zhangliguang@linux.alibaba.com> <1579145331-78633-2-git-send-email-zhangliguang@linux.alibaba.com> Message-ID: Date: Fri, 14 Feb 2020 18:32:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1579145331-78633-2-git-send-email-zhangliguang@linux.alibaba.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Luanshi, On 16/01/2020 03:28, luanshi wrote: > Remove one unnecessary white line. > > Signed-off-by: Liguang Zhang > --- > drivers/firmware/arm_sdei.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c > index 37e9bf0..f81c09e 100644 > --- a/drivers/firmware/arm_sdei.c > +++ b/drivers/firmware/arm_sdei.c > @@ -599,7 +599,6 @@ static int _sdei_event_register(struct sdei_event *event) > event->registered, > SDEI_EVENT_REGISTER_RM_ANY, 0); > > - > err = sdei_do_cross_call(_local_event_register, event); > if (err) { > spin_lock(&event->sdei_event_lock); I'm afraid these whitespace-only patches aren't worth sending. If its not caught at review, it gets to annoy the reader until someone can do a drive-by fix when they are changing adjacent code. I've merged this with the first patch in the eventual series. Thanks, James