All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denis Kenzior <denkenz@gmail.com>
To: James Prestwood <prestwoj@gmail.com>, iwd@lists.linux.dev
Subject: Re: [PATCH v3 04/14] frame-xchg: create global group enum
Date: Fri, 16 Sep 2022 11:06:54 -0500	[thread overview]
Message-ID: <bebd8b2e-2b65-6da5-5d66-2d164aaee5d1@gmail.com> (raw)
In-Reply-To: <20220915220741.1128728-4-prestwoj@gmail.com>

Hi James,

On 9/15/22 17:07, James Prestwood wrote:
> Only P2P utilizes groups for now but to avoid conflicts in group
> numbers for other modules create a global list which can be added
> to as needed.

A non-zero group implies opening a new nl80211 socket.  Do you really need/want 
to do this for FT?

> ---
>   src/frame-xchg.h |  7 +++++++
>   src/p2p.c        | 24 +++++++++---------------
>   2 files changed, 16 insertions(+), 15 deletions(-)
> 
> diff --git a/src/frame-xchg.h b/src/frame-xchg.h
> index 360bb4d4..5b55ded8 100644
> --- a/src/frame-xchg.h
> +++ b/src/frame-xchg.h
> @@ -37,6 +37,13 @@ struct frame_xchg_prefix {
>   	size_t len;
>   };
>   
> +enum frame_xchg_group {
> +	FRAME_GROUP_DEFAULT = 0,
> +	FRAME_GROUP_P2P_LISTEN,
> +	FRAME_GROUP_P2P_CONNECT,
> +	FRAME_GROUP_FT,

Anyway, I dropped the FT enum for now.  It doesn't belong here anyhow. 
Applied, thanks.

Regards,
-Denis

  reply	other threads:[~2022-09-16 16:18 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-15 22:07 [PATCH v3 01/14] frame-xchg: add type to frame_xchg_prefix James Prestwood
2022-09-15 22:07 ` [PATCH v3 02/14] station: don't set OCVC for FT AKMs James Prestwood
2022-09-15 22:07 ` [PATCH v3 03/14] ft: remove OCI element from auth/assoc James Prestwood
2022-09-16 16:05   ` Denis Kenzior
2022-09-16 16:18     ` James Prestwood
2022-09-15 22:07 ` [PATCH v3 04/14] frame-xchg: create global group enum James Prestwood
2022-09-16 16:06   ` Denis Kenzior [this message]
2022-09-16 16:28     ` James Prestwood
2022-09-15 22:07 ` [PATCH v3 05/14] ft: netdev: prep for FT isolation into ft.c James Prestwood
2022-09-15 22:07 ` [PATCH v3 06/14] netdev: use new ft_sm for over-DS James Prestwood
2022-09-15 22:07 ` [PATCH v3 07/14] ft: implement offchannel authentication James Prestwood
2022-09-15 22:07 ` [PATCH v3 08/14] netdev: update FT-over-Air to use ft_authenticate() James Prestwood
2022-09-15 22:07 ` [PATCH v3 09/14] ft: remove unused code after refactor James Prestwood
2022-09-15 22:07 ` [PATCH v3 10/14] ft: add ft_sm_can_associate James Prestwood
2022-09-15 22:07 ` [PATCH v3 11/14] netdev: check for authentication for FT-over-DS James Prestwood
2022-09-15 22:07 ` [PATCH v3 12/14] station: create list of roam candidates James Prestwood
2022-09-15 22:07 ` [PATCH v3 13/14] station: try multiple " James Prestwood
2022-09-15 22:07 ` [PATCH v3 14/14] netdev: add NETDEV_EVENT_FT_AUTHENTICATE, handle in station James Prestwood
2022-09-16 16:04 ` [PATCH v3 01/14] frame-xchg: add type to frame_xchg_prefix Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bebd8b2e-2b65-6da5-5d66-2d164aaee5d1@gmail.com \
    --to=denkenz@gmail.com \
    --cc=iwd@lists.linux.dev \
    --cc=prestwoj@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.