From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/7] drm/i915: Pass proper old/new states to intel_plane_atomic_check_with_state()
Date: Fri, 1 Sep 2017 07:15:55 +0200 [thread overview]
Message-ID: <bec57e81-3af6-e46e-2d58-8a642db3b49e@linux.intel.com> (raw)
In-Reply-To: <20170831185028.GS4914@intel.com>
Op 31-08-17 om 20:50 schreef Ville Syrjälä:
> On Wed, Aug 23, 2017 at 06:22:23PM +0300, ville.syrjala@linux.intel.com wrote:
>> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>
>> Eliminate plane->state and crtc->state usage from
>> intel_plane_atomic_check_with_state() and its callers. Instead pass the
>> proper states in or dig them up from the top level atomic state.
>>
>> Note that intel_plane_atomic_check_with_state() itself isn't allowed to
>> use the top level atomic state as there is none when it gets called from
>> the legacy cursor short circuit path.
>>
>> v2: Rename some variables for easier comprehension (Maarten)
>>
>> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> This patch would still need some review love... In the meantime I
> pushed the first three patches from the series. Thanks for the reviews
> thus far.
I love it.
Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-09-01 5:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-23 15:22 [PATCH 1/7] drm/i915: Pass the new crtc state to color management code ville.syrjala
2017-08-23 15:22 ` [PATCH 2/7] drm/i915: Pass the crtc state explicitly to intel_pipe_update_start/end() ville.syrjala
2017-08-23 15:22 ` [PATCH 3/7] drm/i915: Eliminate obj->state usage in g4x/vlv/chv wm computation ville.syrjala
2017-08-23 15:22 ` [PATCH 4/7] drm/i915: Pass proper old/new states to intel_plane_atomic_check_with_state() ville.syrjala
2017-08-31 18:50 ` Ville Syrjälä
2017-09-01 5:15 ` Maarten Lankhorst [this message]
2017-09-01 13:57 ` Ville Syrjälä
2017-08-23 15:22 ` [PATCH 5/7] drm/i915: Eliminate obj->state usage from pre/post plane update ville.syrjala
2017-08-23 15:22 ` [PATCH 6/7] drm/i915: Eliminate crtc->state usage from intel_update_pipe_config() ville.syrjala
2017-08-23 15:22 ` [PATCH 7/7] drm/i915: Eliminate crtc->state usage from intel_atomic_commit_tail and .crtc_update() ville.syrjala
2017-08-23 15:56 ` ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Pass the new crtc state to color management code Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bec57e81-3af6-e46e-2d58-8a642db3b49e@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.