From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C61B913D8B1 for ; Thu, 11 Apr 2024 06:52:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712818370; cv=none; b=kUTNJQ6lahwEu8u6b15LAVja47RTCRObpJ+K+oBkpfM9modrKgUIVr2KiVCwOzsUmr/8pkHdD4X6fBtzNjc9l7A1oNbrBe5YmDaVHzSGxaXrXIu313RwYk/vubzZS4xmJanq3jc2wbXDgr/SCwYGJSwHKhao5eYUk+D8kYcl2tw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712818370; c=relaxed/simple; bh=OvK2KvKn7oSDGjhgWrRGDX1sEEN9HkUtvDwZ7Zlm9gY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=rSwZBNB5R45f8AC3mtrmocJjOc5PHwAJBnlMGfpy5YxvQhF+eX5+jH49vn/VuBggNaiW3usbN1UgGq1+xkDrorc7IqzYfYK5AjlZucjLviSmEhnWg0hZRBgmK6eo6qn36UZpjmb1OWgbub9wS/Na4rgg75lTvcSrFjRqALjFJ+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Jrk8iEMC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Jrk8iEMC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D922DC433C7; Thu, 11 Apr 2024 06:52:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1712818370; bh=OvK2KvKn7oSDGjhgWrRGDX1sEEN9HkUtvDwZ7Zlm9gY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Jrk8iEMCMwju86KOzXFFwTMPmNTn4iUJCKfFxjWm8MSOCvdWzY7YO9Oemnd2dvYz0 Cy32LnPQmUvDEDAJRKotq+KBUaK3ZdVmZtDPgzu1D3O8vzH3J80map8MdBbb5+Bido bQaPb0p6H0pAEDQMJ5rxx6j6Ci+8eu2yrQCYX4FkBqO3asv7iwu3MKpPOMdQSaGxdg uzeDz22Q9y77vAqixcQtWJGE+f6x7wifrXeMX2h5Pj6Tih6GKDF7vTk9dl57NFTuvg 7sx80OPVpfh9A6Mx4W3+/0l+tBqajRmtWB4ne0IxDjLK+wOC77ILNuRMJVQk+lv6Vv /qJLAM6qNi+OQ== Message-ID: Subject: Re: [PATCH bpf-next v4 3/3] selftests/bpf: Support nonblock for send_recv_data From: Geliang Tang To: Matthieu Baerts , Mat Martineau Cc: mptcp@lists.linux.dev Date: Thu, 11 Apr 2024 14:52:44 +0800 In-Reply-To: <12aab271-da72-49b4-ac91-2091b6889856@linux.dev> References: <9cd358958245f8ec87c4f553779aa4243f967a2f.1712729342.git.tanggeliang@kylinos.cn> <12aab271-da72-49b4-ac91-2091b6889856@linux.dev> Autocrypt: addr=geliang@kernel.org; prefer-encrypt=mutual; keydata=mQINBGWKTg4BEAC/Subk93zbjSYPahLCGMgjylhY/s/R2ebALGJFp13MPZ9qWlbVC8O+XlU/4reZtYKQ715MWe5CwJGPyTACILENuXY0FyVyjp/jl2u6XYnpuhw1ugHMLNJ5vbuwkc1I29nNe8wwjyafN5RQV0AXhKdvofSIryqm0GIHIH/+4bTSh5aB6mvsrjUusB5MnNYU4oDv2L8MBJStqPAQRLlP9BWcKKA7T9SrlgAr0VsFLIOkKOQPVTCnYxn7gfKogH52nkPAFqNofVB6AVWBpr0RTY7OnXRBMInMHcjVG4I/NFn8Cc7oaGaWHqX/yHAufJKUsldieQVFd7C/SI8jCUXdkZxR0Tkp0EUzkRc/TS1VwWHav0x3oLSy/LGHfRaIC/MqdGVqgCnm6wapUt7f/JHloyIyKJBGBuHCLMpN6n/kNkSCzyZKV7h6Vw1OL518p0U3Optyakoh95KiJsKzcd3At/eftQGlNn5WDflHV1+oMdW2sRgfVDPrYeEcYI5IkTc3LRO6ucpVCm9/+poZSHSXMI/oJ6iXMJE8k3/aQz+EEjvc2z0p9aASJPzx0XTTC4lciTvGj62z62rGUlmEIvU23wWH37K2EBNoq+4Y0AZsSvMzM+CcTo25hgPaju1/A8ErZsLhP7IyFT17ARj/Et0G46JRsbdlVJ/PvX+XIOc2mpqx/QARAQABtCVHZWxpYW5nIFRhbmcgPGdlbGlhbmcudGFuZ0BsaW51eC5kZXY+iQJUBBMBCgA+FiEEZiKd+VhdGdcosBcafnvtNTGKqCkFAmWKTg4CGwMFCRLMAwAFCwkIBwIGFQoJCAsCBBYCAwECHgECF4AACgkQfnvtNTGKqCmS+A/9Fec0xGLcrHlpCooiCnNH0RsXOVPsXRp2xQiaOV4vMsvhG5AHaQLb3v0cUr5JpfzMzNpEkaBQ/Y8Oj5hFOORhTyCZD8tY1aROs8WvbxqvbGXHnyVwqy7Ad WelP+0lC0DZW0kPQLeel8XvLnm9Wm3syZgRGxiM/J7PqVcjujUb6SlwfcE3b2opvsHW9AkBNK7v8wGIcmBA3pS1O0/anP/xD5s5L7LIMADVB9MqQdeLdFU+FFdafmKSmcP9A2qKHAvPBUuQo3xoBOZR3DMqXIPkNCBfQGkAx5tm1XYli1u3r5tp5QCRbY5LSkntMNJJh0eWLU8I+zF6NWhqNhHYRD3zc1tiXlG5E0obpX02Dy25SE2zB3abCRdAK30nCI4lMyMCcyaeFqvf6uhiugLiuEPRRRdJDWICOLw6KOFmxWmue1F71k08nj5PQMWQUX3X2K6jiOuoodYwnie/9NsH3DBHIVzVPWASFd6JkZ21i9Ng4ie+iQAveRTCeCCF6VRORJR0R8d7mI9+1eqhNeKzs21gQPVf/KBEIpwPFDjOdTwS/AEQQyhB+5ALeYpNgfKl2p30C20VRfJGBaTc4ReUXh9xbUx5OliV69iq9nIVIyculTUsbrZX81Gz6UlbuSzWc4JclWtXf8/QcOK31wputde7Fl1BTSR4eWJcbE5Iz2yzgQu0IUdlbGlhbmcgVGFuZyA8Z2VsaWFuZ0BrZXJuZWwub3JnPokCVAQTAQoAPhYhBGYinflYXRnXKLAXGn577TUxiqgpBQJlqclXAhsDBQkSzAMABQsJCAcCBhUKCQgLAgQWAgMBAh4BAheAAAoJEH577TUxiqgpaGkP/3+VDnbu3HhZvQJYw9a5Ob/+z7WfX4lCMjUvVz6AAiM2atDyyUoDIv0fkDDUKvqoU9BLU93oiPjVzaR48a1/LZ+RBE2mzPhZF201267XLMFBylb4dyQZxqbAsEhVc9VdjXd4pHYiRTSAUqKqyamh/geIIpJz/cCcDLvX4sM/Zjwt/iQdvCJ2eBzunMfouzryFwLGcOXzxOwZRMOBgVuXrjGVB52kYu1+K90DtclewEgvzWmS9d057CJztJZMXzvHfFAQMgJC7DX4pa Yt49pNvhcqLKMGNLPsX06OR4G+4ai0JTTzIlwVJXuo+uZRFQyuOaSmlSjEsiQ/WsGdhILldV35RiFKe/ojQNd4B4zREBe3xT+Sf5keyAmO/TG14tIOCoGJarkGImGgYltTTTM6rIk/wwo9FWshgKAmQyEEiSzHTSnXcGbalD3Do89YRmdG+5eP7HQfsG+VWdn8IH6qgIvSt8GOw6RfSP7omMXvXji1VrbWG4LOFYcsKTN+dGDhl8LmU0y44HejkCzYj/b28MvNTiRVfucrmZMGgI8L5A4ZwQ3Inv7jY13GZSvTb7PQIbqMcb1P3SqWJFodSwBg9oSw21b+T3aYG3z3MRCDXDlZAJONELx32rPMdBva8k+8L+K8gc7uNVH4jkMPkP9jPnVPx+2P2cKc7LXXedb/qQ3MuQINBGWKTg4BEADJxiOtR4SC7EHrUDVkp/pJCQC2wxNVEiJOas/q7H62BTSjXnXDc8yamb+HDO+Sncg9SrSRaXIh+bw9G3rvOiC2aQKB6EyIWKMcuDlD7GbkLJGRoPCA5nSfHSzht2PdNvbDizODhtBy8BOQA6Vb21XOb1k/hfD8Wy6OnvkA4Er61cf66BzXeTEFrvAIW+eUeoYTBAeOOc2m4Y0J28lXhoQftpNGV5DxH9HSQilQZxEyWkNj8oomVJ6Db7gSHre0odlt5ZdB7eCJik12aPIdK5W97adXrUDAclipsyYmZoC1oRkfUrHZ3aYVgabfC+EfoHnC3KhvekmEfxAPHydGcp80iqQJPjqneDJBOrk6Y51HDMNKg4HJfPV0kujgbF3Oie2MVTuJawiidafsAjP4r7oZTkP0N+jqRmf/wkPe4xkGQRu+L2GTknKtzLAOMAPSh38JqlReQ59G4JpCqLPr00sA9YN+XP+9vOHT9s4iOu2RKy2v4eVOAfEFLXq2JejUQfXZtzSrS/31ThMbfUmZsRi8CY3HRBAENX224Wcn6IsXj3K6lfYxImRKWGa /4KviLias917DT/pjLw/hE8CYubEDpm6cYpHdeAEmsrt/9dMe6flzcNQZlCBgl9zuErP8Cwq8YNO4jN78vRlLLZ5sqgDTWtGWygi/SUj8AUQHyF677QARAQABiQI7BBgBCgAmFiEEZiKd+VhdGdcosBcafnvtNTGKqCkFAmWKTg4CGwwFCRLMAwAACgkQfnvtNTGKqCkpsw/2MuS0PVhl2iXs+MleEhnN1KjeSYaw+nLbRwd2SdXoVXBquPP9Bgb92T2XilcWObNwfVtD2eDz8eKf3e9aaWIzZRQ3E5BxiQSHXl6bDDNaWJB6I8dd5TW+QnBPLzvqxgLIoYn+2FQ0AtL0wpMOdcFg3Av8MEmMJk6s/AHkL8HselA3+4h8mgoK7yMSh601WGrQAFkrWabtynWxHrq4xGfyIPpq56e5ZFPEPd4Ou8wsagn+XEdjDof/QSSjJiIaenCdDiUYrx1jltLmSlN4gRxnlCBp6JYr/7GlJ9Gf26wk25pb9RD6xgMemYQHFgkUsqDulxoBit8g9e0Jlo0gwxvWWSKBJ83f22kKiMdtWIieq94KN8kqErjSXcpI8Etu8EZsuF7LArAPch/5yjltOR5NgbcZ1UBPIPzyPgcAmZlAQgpy5c2UBMmPzxco/A/JVp4pKX8elTc0pS8W7ne8mrFtG7JL0VQfdwNNn2R45VRf3Ag+0pLSLS7WOVQcB8UjwxqDC2t3tJymKmFUfIq8N1DsNrHkBxjs9m3r82qt64u5rBUH3GIO0MGxaI033P+Pq3BXyi1Ur7p0ufsjEj7QCbEAnCPBTSfFEQIBW4YLVPk76tBXdh9HsCwwsrGC2XBmi8ymA05tMAFVq7a2W+TO0tfEdfAX7IENcV87h2yAFBZkaA== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.0-1 Precedence: bulk X-Mailing-List: mptcp@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 mptcp-only Hi Matt & Mat, On Wed, 2024-04-10 at 14:34 -0700, Martin KaFai Lau wrote: > On 4/9/24 11:13 PM, Geliang Tang wrote: > > From: Geliang Tang > >=20 > > Some tests, such as the MPTCP bpf tests, require send_recv_data > > helper > > to run in nonblock mode. > >=20 > > This patch adds nonblock support for send_recv_data(). Check if it > > is > > currently in nonblock mode, and if so, ignore EWOULDBLOCK to > > continue > > sending and receiving. > >=20 > > Signed-off-by: Geliang Tang > > --- > > =C2=A0 tools/testing/selftests/bpf/network_helpers.c | 9 ++++++++- > > =C2=A0 1 file changed, 8 insertions(+), 1 deletion(-) > >=20 > > diff --git a/tools/testing/selftests/bpf/network_helpers.c > > b/tools/testing/selftests/bpf/network_helpers.c > > index 137cd18ef3f2..ca16ef2b648e 100644 > > --- a/tools/testing/selftests/bpf/network_helpers.c > > +++ b/tools/testing/selftests/bpf/network_helpers.c > > @@ -555,6 +555,7 @@ struct send_recv_arg { > > =C2=A0 static void *send_recv_server(void *arg) > > =C2=A0 { > > =C2=A0=C2=A0 struct send_recv_arg *a =3D (struct send_recv_arg *)arg; > > + int flags =3D fcntl(a->fd, F_GETFL); > > =C2=A0=C2=A0 ssize_t nr_sent =3D 0, bytes =3D 0; > > =C2=A0=C2=A0 char batch[1500]; > > =C2=A0=C2=A0 int err =3D 0, fd; > > @@ -578,6 +579,8 @@ static void *send_recv_server(void *arg) > > =C2=A0=C2=A0 if (nr_sent =3D=3D -1 && errno =3D=3D EINTR) > > =C2=A0=C2=A0 continue; > > =C2=A0=C2=A0 if (nr_sent =3D=3D -1) { > > + if (flags & O_NONBLOCK && errno =3D=3D > > EWOULDBLOCK) >=20 > I still don't see why it needs to be a non blocking IO. mptcp should > work > with blocking IO also, no? Does it really need non blocking IO to > make > mptcp test work? I would rather stay with blocking IO in selftest as > much as > possible for simplicity reason. I need some help here. This issue is reported by Matt in "CI: MPTCP BPF tests are now validated", and my fixes ([1] and this patch) aren't accepted by Martin. Is it normal to get EAGAINs in this case? Please give some suggestions. [1] https://patchwork.kernel.org/project/mptcp/patch/311e074a3ca0465bdc5e4c2283= e334bae5ccd306.1711296000.git.tanggeliang@kylinos.cn/ Thanks, -Geliang >=20 > I am afraid the root cause of the EAGAIN thread has not been figured > out yet: > https://lore.kernel.org/all/b3943f9a8bf595212b00e96ba850bf32893312cc.came= l@kernel.org/ >=20 > Lets drop patch 3 until it is understood why mptcp needs EAGAIN or > non-blocking IO. > It feels like there is some flakiness and it should be understood and > avoided. >=20 > Other than the comment in patch 2, the first two patches lgtm. Please > respin with > the first two patches. >=20 > > + continue; > > =C2=A0=C2=A0 err =3D -errno; > > =C2=A0=C2=A0 break; > > =C2=A0=C2=A0 } > > @@ -599,6 +602,7 @@ static void *send_recv_server(void *arg) > > =C2=A0=20 > > =C2=A0 int send_recv_data(int lfd, int fd, uint32_t total_bytes) > > =C2=A0 { > > + int flags =3D fcntl(lfd, F_GETFL); > > =C2=A0=C2=A0 ssize_t nr_recv =3D 0, bytes =3D 0; > > =C2=A0=C2=A0 struct send_recv_arg arg =3D { > > =C2=A0=C2=A0 .fd =3D lfd, > > @@ -622,8 +626,11 @@ int send_recv_data(int lfd, int fd, uint32_t > > total_bytes) > > =C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 MIN(total_bytes - b= ytes, > > sizeof(batch)), 0); > > =C2=A0=C2=A0 if (nr_recv =3D=3D -1 && errno =3D=3D EINTR) > > =C2=A0=C2=A0 continue; > > - if (nr_recv =3D=3D -1) > > + if (nr_recv =3D=3D -1) { > > + if (flags & O_NONBLOCK && errno =3D=3D > > EWOULDBLOCK) > > + continue; > > =C2=A0=C2=A0 break; > > + } > > =C2=A0=C2=A0 bytes +=3D nr_recv; > > =C2=A0=C2=A0 } > > =C2=A0=20 >=20 >=20