From: "Christian König" <christian.koenig@amd.com>
To: Emily Deng <Emily.Deng@amd.com>, amd-gfx@lists.freedesktop.org
Subject: Re: [PATCH v3] drm/ttm: Should to return the evict error
Date: Wed, 4 Jun 2025 11:00:27 +0200 [thread overview]
Message-ID: <becc0fd4-cb6f-49b5-8197-a755d3c5a359@amd.com> (raw)
In-Reply-To: <20250603091154.3472646-1-Emily.Deng@amd.com>
On 6/3/25 11:11, Emily Deng wrote:
> For the evict fail case, the evict error should be returned.
>
> v2: Consider ENOENT case.
>
> v3: Abort directly when the eviction failed for some reason (except for -ENOENT)
> and not wait for the move to finish
>
> Signed-off-by: Emily Deng <Emily.Deng@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/ttm/ttm_resource.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_resource.c b/drivers/gpu/drm/ttm/ttm_resource.c
> index 7e5a60c55813..bb84528276cd 100644
> --- a/drivers/gpu/drm/ttm/ttm_resource.c
> +++ b/drivers/gpu/drm/ttm/ttm_resource.c
> @@ -558,6 +558,9 @@ int ttm_resource_manager_evict_all(struct ttm_device *bdev,
> cond_resched();
> } while (!ret);
>
> + if (ret && ret != -ENOENT)
> + return ret;
> +
> spin_lock(&man->move_lock);
> fence = dma_fence_get(man->move);
> spin_unlock(&man->move_lock);
next prev parent reply other threads:[~2025-06-04 9:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 9:11 [PATCH v3] drm/ttm: Should to return the evict error Emily Deng
2025-06-04 3:17 ` Deng, Emily
2025-06-04 9:00 ` Christian König [this message]
2025-06-06 16:55 ` Alex Deucher
2025-06-10 8:47 ` Christian König
-- strict thread matches above, loose matches on Subject: below --
2025-06-03 9:09 Emily Deng
2025-06-03 9:12 ` Deng, Emily
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=becc0fd4-cb6f-49b5-8197-a755d3c5a359@amd.com \
--to=christian.koenig@amd.com \
--cc=Emily.Deng@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.