From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH v3 10/16] phy: qcom-qmp: Move register offsets to header file Date: Wed, 22 Nov 2017 09:26:58 -0800 Message-ID: References: <1511256206-1587-1-git-send-email-mgautam@codeaurora.org> <1511256206-1587-11-git-send-email-mgautam@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:49168 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751554AbdKVR1B (ORCPT ); Wed, 22 Nov 2017 12:27:01 -0500 In-Reply-To: <1511256206-1587-11-git-send-email-mgautam@codeaurora.org> Content-Language: en-US Sender: linux-arm-msm-owner@vger.kernel.org List-Id: linux-arm-msm@vger.kernel.org To: Manu Gautam , Kishon Vijay Abraham I Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, Vivek Gautam , Varadarajan Narayanan , Wei Yongjun , Fengguang Wu , open list On 11/21/2017 01:23 AM, Manu Gautam wrote: > New revision (v3) of QMP PHY uses different offsets > for almost all of the registers. Hence, move these > definitions to header file so that updated offsets > can be added for QMP v3. > > Signed-off-by: Manu Gautam > --- Why? It would only be included into one C file so it's really not necessary. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project