From: christian--- via buildroot <buildroot@buildroot.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Christian Hitz via buildroot <buildroot@buildroot.org>,
Christian Hitz <christian.hitz@bbv.ch>,
Jesse Van Gavere <jesseevg@gmail.com>,
Samuel Martin <s.martin49@gmail.com>,
Roy Kollen Svendsen <roykollensvendsen@gmail.com>
Subject: Re: [Buildroot] [PATCH] package/qt6/qt6connectivity: new package
Date: Thu, 06 Mar 2025 10:35:15 +0100 [thread overview]
Message-ID: <bee30fc3929533d2704cfed5834b5989@klarinett.li> (raw)
In-Reply-To: <20240914132142.22afe629@windsurf>
Hello Thomas
Thanks for the review.
Am 2024-09-14 13:21, schrieb Thomas Petazzoni:
>> +++ b/package/qt6/qt6connectivity/Config.in
>> @@ -0,0 +1,18 @@
>> +config BR2_PACKAGE_QT6CONNECTIVITY
>> + bool "qt6connectivity"
>> + depends on BR2_PACKAGE_NEARD || BR2_PACKAGE_BLUEZ5_UTILS
>
> There is nothing related to neard support in qt6connectivity as far as
> I can see.
The qt6connectivity module uses neard to provide NFC services on Linux.
[1]
DBus is used to communicate with neard. Technically, the neard
dependency is runtime only.
>
> Also, I believe bluez is not mandatory. I've done a build of
> qt6connectivity with neither neard nor bluez5-utils and it did
> build/install Qt6Nfc.
I tried to reduce the bluez dependency down to runtime-only, but if
bluez is not available at compile time, QBluetooth is only built
with a dummy backend, skipping the relevant bluez backend.
>
>> + select BR2_PACKAGE_QT6BASE_NETWORK
>> + select BR2_PACKAGE_QT6BASE_CONCURRENT
>> + select BR2_PACKAGE_QT6BASE_DBUS
>
> Concurrent is definitely not needed.
Agreed.
> DBus doesn't seem to be mandatory either (I tested to build without it,
> and it built fine).
Network and DBus are required to build. [2] [3] [4]
I will sent a v2 version addressing these points.
Regards,
Christian
[1]
https://github.com/qt/qtconnectivity/blob/817a2ccffba47d5dd1175a2a10e8ac6628570314/src/nfc/configure.cmake#L10
[2]
https://github.com/qt/qtconnectivity/blob/817a2ccffba47d5dd1175a2a10e8ac6628570314/src/bluetooth/CMakeLists.txt#L45
[3]
https://github.com/qt/qtconnectivity/blob/817a2ccffba47d5dd1175a2a10e8ac6628570314/src/bluetooth/CMakeLists.txt#L96
[4]
https://github.com/qt/qtconnectivity/blob/817a2ccffba47d5dd1175a2a10e8ac6628570314/src/nfc/CMakeLists.txt#L113
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2025-03-06 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-11 13:12 [Buildroot] [PATCH] package/qt6/qt6connectivity: new package Christian Hitz via buildroot
2024-09-14 11:21 ` Thomas Petazzoni via buildroot
2025-03-06 9:35 ` christian--- via buildroot [this message]
2025-03-06 11:54 ` [Buildroot] [PATCH v2] " Christian Hitz via buildroot
2025-03-06 19:35 ` Roy Kollen Svendsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bee30fc3929533d2704cfed5834b5989@klarinett.li \
--to=buildroot@buildroot.org \
--cc=christian.hitz@bbv.ch \
--cc=christian@klarinett.li \
--cc=jesseevg@gmail.com \
--cc=roykollensvendsen@gmail.com \
--cc=s.martin49@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.