All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Lechner <dlechner@baylibre.com>
To: Jorge Ramirez-Ortiz <jorge.ramirez@oss.qualcomm.com>,
	trini@konsulko.com,  jens.wiklander@linaro.org,
	ilias.apalodimas@linaro.org, peng.fan@nxp.com,
	 jh80.chung@samsung.com, neil.armstrong@linaro.org,
	bhupesh.linux@gmail.com, n-francis@ti.com, xypron.glpk@gmx.de,
	marek.vasut+renesas@mailbox.org,
	igor.belwon@mentallysanemainliners.org, shawn.lin@rock-chips.com,
	tuyen.dang.xa@renesas.com, yoshihiro.shimoda.uh@renesas.com,
	padmarao.begari@amd.com, macpaul.lin@mediatek.com,
	jstephan@baylibre.com, hayashi.kunihiko@socionext.com,
	j-mcarthur@ti.com, venkyada@qti.qualcomm.com
Cc: u-boot@lists.denx.de, u-boot@lists.u-boot-project.org
Subject: Re: [PATCH v4 1/5] ufs: decode string descriptors as UTF-16 big-endian
Date: Wed, 9 Sep 2026 11:13:27 -0500	[thread overview]
Message-ID: <beee887d-b2a2-4338-89f1-380fde44162f@baylibre.com> (raw)
In-Reply-To: <9e05bc7b-be99-40f7-8c64-259e92f92148@baylibre.com>

On 9/9/26 11:11 AM, David Lechner wrote:
> On 8/7/26 9:01 AM, Jorge Ramirez-Ortiz wrote:
>> UFS string descriptors are UTF-16 big-endian (JESD220), but
>> ufshcd_read_string_desc() fed the raw bytes to utf16_to_utf8(), which reads
>> host-endian code units, leaving dev_desc->model blank.
>>
>> Add an endian parameter to utf16_to_utf8() so the caller can specify the byte
>> order of the source, and pass UTF16_BIG_ENDIAN from the UFS driver, matching
>> the kernel's utf16s_to_utf8s(..., UTF16_BIG_ENDIAN). Existing callers keep
>> their current behaviour via UTF16_HOST_ENDIAN.
> 
Probably deserves a Fixes: tag as well.

      reply	other threads:[~2026-09-09 16:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260807140119.324858-1-jorge.ramirez@oss.qualcomm.com>
     [not found] ` <aoMc8FDcE0bYGZch@trex>
     [not found]   ` <aohaajBy5e6A4gFL@trex>
     [not found]     ` <ao_89VbNNE1QTX6a@trex>
     [not found]       ` <ap5i9edBJ7sNVmax@trex>
     [not found]         ` <61fd743d-c722-42b8-a754-175715a4bcbe@ti.com>
     [not found]           ` <ap54m53aTMXhIso3@trux>
2026-09-07 16:13             ` [PATCH v4 0/5] ufs: rpmb: route OP-TEE RPMB secure storage over UFS Tom Rini
2026-09-07 19:16               ` Jorge Ramirez
2026-09-07 19:36                 ` Tom Rini
2026-09-07 21:28                   ` Jorge Ramirez
2026-09-08  7:30                 ` Peter Robinson
     [not found]             ` <d191ab8c-3c5f-46c4-8278-9644a508470b@linaro.org>
2026-09-08  9:47               ` Jorge Ramirez
     [not found] ` <20260807140119.324858-2-jorge.ramirez@oss.qualcomm.com>
2026-09-09 16:11   ` [PATCH v4 1/5] ufs: decode string descriptors as UTF-16 big-endian David Lechner
2026-09-09 16:13     ` David Lechner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=beee887d-b2a2-4338-89f1-380fde44162f@baylibre.com \
    --to=dlechner@baylibre.com \
    --cc=bhupesh.linux@gmail.com \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=igor.belwon@mentallysanemainliners.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=j-mcarthur@ti.com \
    --cc=jens.wiklander@linaro.org \
    --cc=jh80.chung@samsung.com \
    --cc=jorge.ramirez@oss.qualcomm.com \
    --cc=jstephan@baylibre.com \
    --cc=macpaul.lin@mediatek.com \
    --cc=marek.vasut+renesas@mailbox.org \
    --cc=n-francis@ti.com \
    --cc=neil.armstrong@linaro.org \
    --cc=padmarao.begari@amd.com \
    --cc=peng.fan@nxp.com \
    --cc=shawn.lin@rock-chips.com \
    --cc=trini@konsulko.com \
    --cc=tuyen.dang.xa@renesas.com \
    --cc=u-boot@lists.denx.de \
    --cc=u-boot@lists.u-boot-project.org \
    --cc=venkyada@qti.qualcomm.com \
    --cc=xypron.glpk@gmx.de \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.