From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EF33C6FD18 for ; Tue, 25 Apr 2023 06:24:26 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id DBC368621F; Tue, 25 Apr 2023 08:24:21 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="jmP5avHT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id E828A86201; Tue, 25 Apr 2023 08:24:19 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D156385B21 for ; Tue, 25 Apr 2023 08:24:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=n-francis@ti.com Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33P6O80v113886; Tue, 25 Apr 2023 01:24:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1682403848; bh=rJYv6RDkVwTx95IJEtOH3Q6e6vJ7cB3ey56OeNEvEXw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=jmP5avHTtQxz3QJeaHLEQeZVFwAojY+Wj7ODQBw14iYr3XJnC1TLAqTQl42BBSJMg LJMaxYGQFmfhz5W0nLfjxYibI1SpEX6DSghjMW3x/g7Od6VxkMrB77ecfWtEU6iILn 9Mh6/COkzhArNx94/PolsC52Bj6rNwAECqUfOEec= Received: from DLEE111.ent.ti.com (dlee111.ent.ti.com [157.170.170.22]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33P6O8Nf114933 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Apr 2023 01:24:08 -0500 Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 25 Apr 2023 01:24:08 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 25 Apr 2023 01:24:08 -0500 Received: from [172.24.145.195] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33P6O4Yo001492; Tue, 25 Apr 2023 01:24:05 -0500 Message-ID: Date: Tue, 25 Apr 2023 11:54:04 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 01/19] binman: ti-board-config: Add support for TI board config binaries Content-Language: en-US To: Simon Glass CC: , , , , , , , , References: <20230421123203.1315330-1-n-francis@ti.com> <20230421123203.1315330-2-n-francis@ti.com> From: Neha Malcom Francis In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Simon On 25/04/23 01:12, Simon Glass wrote: > Hi Neha, > > On Fri, 21 Apr 2023 at 06:32, Neha Malcom Francis wrote: >> >> The ti-board-config entry loads and validates a given YAML config file >> against a given schema, and generates the board config binary. K3 >> devices require these binaries to be packed into the final system >> firmware images. >> >> Signed-off-by: Neha Malcom Francis >> --- >> tools/binman/entries.rst | 48 ++++ >> tools/binman/etype/ti_board_config.py | 269 ++++++++++++++++++ >> tools/binman/ftest.py | 32 +++ >> tools/binman/pyproject.toml | 2 +- >> tools/binman/test/277_ti_board_cfg.dts | 11 + >> .../binman/test/278_ti_board_cfg_combined.dts | 25 ++ >> .../binman/test/279_ti_board_cfg_no_type.dts | 11 + >> .../binman/test/280_ti_board_cfg_no_file.dts | 11 + >> .../281_ti_board_cfg_combined_no_file.dts | 13 + >> tools/binman/test/yaml/config.yaml | 19 ++ >> tools/binman/test/yaml/schema.yaml | 51 ++++ >> tools/binman/test/yaml/schema_notype.yaml | 40 +++ >> 12 files changed, 531 insertions(+), 1 deletion(-) >> create mode 100644 tools/binman/etype/ti_board_config.py >> create mode 100644 tools/binman/test/277_ti_board_cfg.dts >> create mode 100644 tools/binman/test/278_ti_board_cfg_combined.dts >> create mode 100644 tools/binman/test/279_ti_board_cfg_no_type.dts >> create mode 100644 tools/binman/test/280_ti_board_cfg_no_file.dts >> create mode 100644 tools/binman/test/281_ti_board_cfg_combined_no_file.dts >> create mode 100644 tools/binman/test/yaml/config.yaml >> create mode 100644 tools/binman/test/yaml/schema.yaml >> create mode 100644 tools/binman/test/yaml/schema_notype.yaml >> > > Reviewed-by: Simon Glass > > My only real comment is that errors should produce an error rather > than just a warning. E.g. a schema-validation error should be fatal, > since it won't work. > > You can call self.Raise() when something goes wrong. The tests should > check for that instead of a warning. > Makes sense. But I'm not sure I understand when we create an fake binary and when we choose to throw errors? Either case we end up with non-working binary or no binary at all. I see both styles in existing etypes and I can't form a reasoning for when to do what. > Regards, > Simon -- Thanking You Neha Malcom Francis