From: Mike Kravetz <mike.kravetz@oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: cgxu519@mykernel.net, linux-mm <linux-mm@kvack.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] hugetlbfs: fix error handling in init_hugetlbfs_fs()
Date: Tue, 29 Oct 2019 15:36:37 -0700 [thread overview]
Message-ID: <befca227-cb8a-8f47-617d-e3bf9972bfec@oracle.com> (raw)
In-Reply-To: <20191029152442.32bf51a13e48d9b2d83cd504@linux-foundation.org>
On 10/29/19 3:24 PM, Andrew Morton wrote:
> On Tue, 29 Oct 2019 13:47:38 -0700 Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
>> It is assumed that the hugetlbfs_vfsmount[] array will contain
>> either a valid vfsmount pointer or NULL for each hstate after
>> initialization. Changes made while converting to use fs_context
>> broke this assumption.
>>
>> While fixing the hugetlbfs_vfsmount issue, it was discovered that
>> init_hugetlbfs_fs never did correctly clean up when encountering
>> a vfs mount error.
>
> What were the user-visible runtime effects of this bug?
>
> (IOW: why does it warrant the cc:stable?)
On second thought, let's not cc stable.
It was found during code inspection. A small memory allocation failure
would be the most likely cause of taking a error path with the bug. This
is unlikely to happen as this is early init code.
Sorry about that,
--
Mike Kravetz
prev parent reply other threads:[~2019-10-29 22:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-17 10:38 [PATCH] hugetlbfs: fix error handling in init_hugetlbfs_fs() Chengguang Xu
2019-10-18 0:08 ` Mike Kravetz
2019-10-18 0:47 ` Mike Kravetz
2019-10-28 21:27 ` Mike Kravetz
2019-10-29 4:36 ` Chengguang Xu
2019-10-29 20:47 ` Mike Kravetz
2019-10-29 22:24 ` Andrew Morton
2019-10-29 22:36 ` Mike Kravetz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=befca227-cb8a-8f47-617d-e3bf9972bfec@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=cgxu519@mykernel.net \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.