From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Hongyu Xie <xy521521@gmail.com>,
mathias.nyman@intel.com, gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
125707942@qq.com, wangqi@kylinos.cn, xiongxin@kylinos.cn,
Hongyu Xie <xiehongyu1@kylinos.cn>
Subject: Re: [PATCH v5 -next] usb: xhci: disable irq during initialization
Date: Tue, 21 Jun 2022 11:25:16 +0300 [thread overview]
Message-ID: <bf133cfd-8d9a-474e-989e-48fe383ecfbd@linux.intel.com> (raw)
In-Reply-To: <20220616083852.1264261-1-xiehongyu1@kylinos.cn>
Hi
On 16.6.2022 11.38, Hongyu Xie wrote:
> irq is disabled in xhci_quiesce(called by xhci_halt, with bit:2 cleared
> in USBCMD register), but xhci_run(called by usb_add_hcd) re-enable it.
> It's possible that you will receive thousands of interrupt requests
> after initialization for 2.0 roothub. And you will get a lot of
> warning like, "xHCI dying, ignoring interrupt. Shouldn't IRQs be
> disabled?". This amount of interrupt requests will cause the entire
> system to freeze.
> This problem was first found on a device with ASM2142 host controller
> on it.
>
> Signed-off-by: Hongyu Xie <xiehongyu1@kylinos.cn>
> --
Thanks, added.
Did some non-functional cleanups, mostly to the old debug messages this patch
moves around:
https://git.kernel.org/pub/scm/linux/kernel/git/mnyman/xhci.git/commit/?h=for-usb-linus&id=2d1fa9b0b08bb841fde9136c249f632eb04a1e00
Let me know if you disagree with the changes
-Mathias
next prev parent reply other threads:[~2022-06-21 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-16 8:38 [PATCH v5 -next] usb: xhci: disable irq during initialization Hongyu Xie
2022-06-21 8:25 ` Mathias Nyman [this message]
2022-06-21 8:40 ` 谢泓宇
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf133cfd-8d9a-474e-989e-48fe383ecfbd@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=125707942@qq.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=wangqi@kylinos.cn \
--cc=xiehongyu1@kylinos.cn \
--cc=xiongxin@kylinos.cn \
--cc=xy521521@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.