All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karolina Drobnik <karolinadrobnik@gmail.com>
To: Praveen Kumar <kpraveen.lkml@gmail.com>,
	 outreachy-kernel@googlegroups.com
Cc: gregkh@linuxfoundation.org, forest@alittletooquiet.net,
	 linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [Outreachy kernel] [PATCH 5/5] staging: vt6655: Rename `byRFType` variable
Date: Fri, 22 Oct 2021 16:58:02 +0100	[thread overview]
Message-ID: <bf2a82e5a5f296ea66bda0cef84acbf78e88ffe3.camel@gmail.com> (raw)
In-Reply-To: <049d4b3e-ed32-9b48-0c2e-19f9af95ca37@gmail.com>

Hi Praveen,

Thanks for taking a look at my patch.

On Fri, 2021-10-22 at 19:56 +0530, Praveen Kumar wrote:
> IMO, probably we can sync RFbSelectChannel as well with similar
> notation in another patch.
> 
> >  bool RFbInit(struct vnt_private *priv);
> > -bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char
> > byRFType, u16 channel);
> > +bool RFvWriteWakeProgSyn(struct vnt_private *priv, unsigned char
> > rf_type, u16 channel);
> >  bool RFbSetPower(struct vnt_private *priv, unsigned int rate, u16
> > uCH);
> >  bool RFbRawSetPower(struct vnt_private *priv, unsigned char byPwr,
> >                     unsigned int rate);

That's a good idea. I plan to clean up `RFvWriteWakeProgSyn` completely
first and then I can move on to this one.


Thanks,
Karolina



      reply	other threads:[~2021-10-22 15:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-22  9:37 [PATCH 0/5] staging: vt6655: `RFvWriteWakeProgSyn` variables rename Karolina Drobnik
2021-10-22  9:37 ` [PATCH 1/5] staging: vt6655: Rename `ii` variable Karolina Drobnik
2021-10-22  9:37 ` [PATCH 2/5] staging: vt6655: Rename `byInitCount` variable Karolina Drobnik
2021-10-22 16:40   ` [Outreachy kernel] " Alison Schofield
2021-10-25  9:38     ` Karolina Drobnik
2021-10-22  9:37 ` [PATCH 3/5] staging: vt6655: Rename `bySleepCount` variable Karolina Drobnik
2021-10-22  9:37 ` [PATCH 4/5] staging: vt6655: Rename `uChannel` variable Karolina Drobnik
2021-10-22  9:37 ` [PATCH 5/5] staging: vt6655: Rename `byRFType` variable Karolina Drobnik
2021-10-22 14:26   ` [Outreachy kernel] " Praveen Kumar
2021-10-22 15:58     ` Karolina Drobnik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf2a82e5a5f296ea66bda0cef84acbf78e88ffe3.camel@gmail.com \
    --to=karolinadrobnik@gmail.com \
    --cc=forest@alittletooquiet.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=kpraveen.lkml@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.