All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sourabh Jain <sourabhjain@linux.ibm.com>
To: Hari Bathini <hbathini@linux.ibm.com>,
	linuxppc-dev@ozlabs.org, mpe@ellerman.id.au
Cc: mahesh@linux.vnet.ibm.com
Subject: Re: [PATCH] powerpc/kexec_file: account hot-pluggable memory while estimating FDT size
Date: Fri, 16 Dec 2022 15:55:08 +0530	[thread overview]
Message-ID: <bf32e6b4-1271-e20a-3eb7-003c9b7b4935@linux.ibm.com> (raw)
In-Reply-To: <8253623b-bf9b-4407-999f-506aa8c7e38f@linux.ibm.com>


On 16/12/22 11:45, Hari Bathini wrote:
>
>
> On 15/12/22 2:08 pm, Sourabh Jain wrote:
>> On Systems where online memory is lesser compared to max memory, the
>> kexec_file_load system call may fail to load the kdump kernel with the
>> below errors:
>>
>>      "Failed to update fdt with linux,drconf-usable-memory property"
>>      "Error setting up usable-memory property for kdump kernel"
>>
>> This happens because the size estimation for usable memory properties
>> for the kdump kernel's FDT is based on the online memory whereas the
>> usable memory properties include max memory. In short, the hot-pluggable
>> memory is not accounted for while estimating the size of the usable
>> memory properties.
>>
>> The issue is addressed by calculating usable memory property size using
>> max hotplug address instead of the last online memory address.
>>
>> Fixes: 2377c92e37fe ("powerpc/kexec_file: fix FDT size estimation for 
>> kdump kernel")
>> Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
>
> Thanks for the fix, Sourabh. Looks good to me.
>
> Acked-by: Hari Bathini <hbathini@linux.ibm.com>

Thanks Hari.

- Sourabh Jain


  reply	other threads:[~2022-12-16 10:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15  8:38 [PATCH] powerpc/kexec_file: account hot-pluggable memory while estimating FDT size Sourabh Jain
2022-12-16  6:15 ` Hari Bathini
2022-12-16 10:25   ` Sourabh Jain [this message]
2023-01-27  5:56 ` Sourabh Jain
2023-01-30  3:04 ` Michael Ellerman
2023-01-30  4:49   ` Sourabh Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf32e6b4-1271-e20a-3eb7-003c9b7b4935@linux.ibm.com \
    --to=sourabhjain@linux.ibm.com \
    --cc=hbathini@linux.ibm.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=mpe@ellerman.id.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.