From mboxrd@z Thu Jan  1 00:00:00 1970
From: Kevin Traynor <ktraynor@redhat.com>
Subject: Re: [PATCH v1 1/2] net/i40e: fix incorrect xstats value
 mapping
Date: Mon, 14 Nov 2016 17:59:40 +0000
Message-ID: <bf415c8c-05fb-ce70-05da-16191b8cf59e@redhat.com>
References: <1479104089-27862-1-git-send-email-remy.horton@intel.com>
 <1479104089-27862-2-git-send-email-remy.horton@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Cc: Helin Zhang <helin.zhang@intel.com>, Jingjing Wu <jingjing.wu@intel.com>,
 stable@dpdk.org, Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: Remy Horton <remy.horton@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <1479104089-27862-2-git-send-email-remy.horton@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 11/14/2016 06:14 AM, Remy Horton wrote:
> The offsets used in rte_i40evf_stats_strings for transmission
> statistics were wrong, returning the total byte count rather than
> the respective (unicast, multicast, broadcast, drop, & error)
> packet counts.
> 
> Fixes: da61cd084976 ("i40evf: add extended stats")

This should go to the LTS branch also.

Acked-by: Kevin Traynor <ktraynor@redhat.com>

> 
> Signed-off-by: Remy Horton <remy.horton@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev_vf.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/i40e/i40e_ethdev_vf.c b/drivers/net/i40e/i40e_ethdev_vf.c
> index aa306d6..afae2ec 100644
> --- a/drivers/net/i40e/i40e_ethdev_vf.c
> +++ b/drivers/net/i40e/i40e_ethdev_vf.c
> @@ -176,11 +176,11 @@ static const struct rte_i40evf_xstats_name_off rte_i40evf_stats_strings[] = {
>  	{"rx_unknown_protocol_packets", offsetof(struct i40e_eth_stats,
>  		rx_unknown_protocol)},
>  	{"tx_bytes", offsetof(struct i40e_eth_stats, tx_bytes)},
> -	{"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_bytes)},
> -	{"tx_multicast_packets", offsetof(struct i40e_eth_stats, tx_bytes)},
> -	{"tx_broadcast_packets", offsetof(struct i40e_eth_stats, tx_bytes)},
> -	{"tx_dropped_packets", offsetof(struct i40e_eth_stats, tx_bytes)},
> -	{"tx_error_packets", offsetof(struct i40e_eth_stats, tx_bytes)},
> +	{"tx_unicast_packets", offsetof(struct i40e_eth_stats, tx_unicast)},
> +	{"tx_multicast_packets", offsetof(struct i40e_eth_stats, tx_multicast)},
> +	{"tx_broadcast_packets", offsetof(struct i40e_eth_stats, tx_broadcast)},
> +	{"tx_dropped_packets", offsetof(struct i40e_eth_stats, tx_discards)},
> +	{"tx_error_packets", offsetof(struct i40e_eth_stats, tx_errors)},
>  };
>  
>  #define I40EVF_NB_XSTATS (sizeof(rte_i40evf_stats_strings) / \
>