From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1E7CC433EF for ; Fri, 25 Mar 2022 07:31:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353070AbiCYHdM (ORCPT ); Fri, 25 Mar 2022 03:33:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58238 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353861AbiCYHdC (ORCPT ); Fri, 25 Mar 2022 03:33:02 -0400 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E87C7C4E16; Fri, 25 Mar 2022 00:31:28 -0700 (PDT) Received: by mail-wm1-f52.google.com with SMTP id bi13-20020a05600c3d8d00b0038c2c33d8f3so8466990wmb.4; Fri, 25 Mar 2022 00:31:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GuILc5kRDriiMUiIXV7yGyzOLFCBv5MwLQdIg/dr7Gg=; b=2MwnyaHIDCeOMjlyuMw16yPfLLAiMAkijo9erxkIgOLDmoQso8QIpt4W29MN6HH4aN HHwAZYkbNQVVYhjAbnWIDfRTjr4Nj3ZBLbgdHwVLmOveclYAVgj5xYaOoCUtEK2xwqtj LknRocmXioSGWxQuMUZ0VjF4IRW8e+LzwDtLiBvLOPAXLpApjFRto4LsUc9ydN7wDue2 R+cwCdTW6plVHnr3SGvyWtqkvZnyEfNTish0zHeDZSxJ/t2BuGssK4DTBrgDPVrcSAbX m4yhNEC7jUNIOCUawlP0tPBICJmFTh3l8/DXSAs7uvAYpedvst0fZRcptIbauwuBUtLE +HRg== X-Gm-Message-State: AOAM533+xmho4XDp4AnucDNHcUIm7vwMomv1SSvv3izFohKuKZbJHJ+e rtgPfayOGg1r/uuxkIygesw= X-Google-Smtp-Source: ABdhPJxX9+mei/tkczYkXDnJ8Ea8iol1WorIaCdEFNkBNxZcDCKU/ZfZR2wP0DOrgOPfGrPat8W3eA== X-Received: by 2002:a05:600c:3b86:b0:38c:afdf:66cd with SMTP id n6-20020a05600c3b8600b0038cafdf66cdmr17701222wms.198.1648193487331; Fri, 25 Mar 2022 00:31:27 -0700 (PDT) Received: from [192.168.0.158] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.googlemail.com with ESMTPSA id u7-20020a5d6da7000000b00203d9d1875bsm5199505wrs.73.2022.03.25.00.31.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Mar 2022 00:31:26 -0700 (PDT) Message-ID: Date: Fri, 25 Mar 2022 08:31:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v1] dt-bindings: clock: convert rockchip,rk3188-cru.txt to YAML Content-Language: en-US To: Stephen Boyd , Johan Jonker , heiko@sntech.de Cc: robh+dt@kernel.org, krzk+dt@kernel.org, mturquette@baylibre.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220324133229.24035-1-jbx6244@gmail.com> <20220325005130.C45A3C340EC@smtp.kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220325005130.C45A3C340EC@smtp.kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-clk@vger.kernel.org On 25/03/2022 01:51, Stephen Boyd wrote: > Quoting Johan Jonker (2022-03-24 12:51:36) >> Hi Heiko, Krzysztof, >> >> Question for the Rockchip clock maintainer: >> What clock should be used here and other SoCs with several clock parents >> in the tree? >> >> The clock.yaml produces a lot off notifications like: >> >> /arch/arm/boot/dts/rk3036-evb.dtb: clock-controller@20000000: 'clocks' >> is a dependency of 'assigned-clocks' > > 'clocks' is not a dependency of 'assigned-clocks'. The dt-schema should > be fixed to remove that requirement. If the driver does not have any clock inputs ("clocks" property), why does it care about some clock frequencies and parents? The clocks is the logical dependency of assigned-clocks, because otherwise hardware description is not complete. What should be here for Rockhip? We had similar cases like this for many drivers, I was fixing some of Exynos as well. In my case usually the root/external clock was missing, so I supplied is as input clock to the clock controller. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 609EFC433F5 for ; Fri, 25 Mar 2022 07:31:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=128j/e8BQTV/izmW+ICwOwsLQvqcVqUvgKLyIsUeKkQ=; b=KFOpwd2jF30izt 2igHVf3Sw999y6EtUBAy3zWWXcN4Kl/Suu8UGi4AV3X22DxlXoqdfljJNdQ2/NO4gUMWG0sLSOHuH Nu+GnHWU67LX1HHjLihBEpsukqZRnCYr/QhjDWIq2fxIsxgm/oyoGxTDAapIgtmToJybZdhLv6Tb6 vNUNGWAJw2mAU1Z7U/F2nzJzaY/Uj0uetJSGbEOdVu2nfPg/gBASfLv6NqFgNopZTvNJtUrfnYEIp wOydwoayzdF61SuhEOdtcBx/BKn2qMKyLZL5eDCgKcwRgCuCnwCSrGzwdiJzYZKjb/dZ0k+Ij77I9 tU2UG/MusryRh8wDcelg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXeQ9-001LVE-GJ; Fri, 25 Mar 2022 07:31:41 +0000 Received: from mail-wm1-f50.google.com ([209.85.128.50]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXePx-001LTV-Cc; Fri, 25 Mar 2022 07:31:30 +0000 Received: by mail-wm1-f50.google.com with SMTP id i67-20020a1c3b46000000b0038ce25c870dso380879wma.1; Fri, 25 Mar 2022 00:31:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GuILc5kRDriiMUiIXV7yGyzOLFCBv5MwLQdIg/dr7Gg=; b=W8ad+geeroQ+Zd+eXxCQaLhCdYlvYyotHKAtrt5XHMIe8yU1MZQVQO1R6J8EEp+dwo 8lIBve08t3o1fuPmEFlMS2BL2RsR1L71XGpgxztmzF+H+SbBQNwqsLNktbCs7uV9Hjxy hMIkPpwLYH5I2VTOR6A+56oy97DmySycjpzdDNkuhckWEtJUAvOr/NQtyK29RKynfHMB 6stwO8iFEJGiFBL5RczDXwLDIIiKB8rI2lFP41PQE8lzZhpBFTNsR1KFcXLz8CYvP0oG XJuHnWIQuGIoSLXsxW/UNT/AvmaCiLFZL09zzOgZ65fEjE8unb7W9Rc+B7YRNkuoP7zO AMtQ== X-Gm-Message-State: AOAM532KAyKomvBHYcaHnaTopTXSUGzNLWwMPOjaqA7QpBJ3ERMImj95 U1TMaNkOkWNpc/TAdZFRWv0= X-Google-Smtp-Source: ABdhPJxX9+mei/tkczYkXDnJ8Ea8iol1WorIaCdEFNkBNxZcDCKU/ZfZR2wP0DOrgOPfGrPat8W3eA== X-Received: by 2002:a05:600c:3b86:b0:38c:afdf:66cd with SMTP id n6-20020a05600c3b8600b0038cafdf66cdmr17701222wms.198.1648193487331; Fri, 25 Mar 2022 00:31:27 -0700 (PDT) Received: from [192.168.0.158] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.googlemail.com with ESMTPSA id u7-20020a5d6da7000000b00203d9d1875bsm5199505wrs.73.2022.03.25.00.31.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Mar 2022 00:31:26 -0700 (PDT) Message-ID: Date: Fri, 25 Mar 2022 08:31:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v1] dt-bindings: clock: convert rockchip, rk3188-cru.txt to YAML Content-Language: en-US To: Stephen Boyd , Johan Jonker , heiko@sntech.de Cc: robh+dt@kernel.org, krzk+dt@kernel.org, mturquette@baylibre.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220324133229.24035-1-jbx6244@gmail.com> <20220325005130.C45A3C340EC@smtp.kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220325005130.C45A3C340EC@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220325_003129_466808_5129BDA3 X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On 25/03/2022 01:51, Stephen Boyd wrote: > Quoting Johan Jonker (2022-03-24 12:51:36) >> Hi Heiko, Krzysztof, >> >> Question for the Rockchip clock maintainer: >> What clock should be used here and other SoCs with several clock parents >> in the tree? >> >> The clock.yaml produces a lot off notifications like: >> >> /arch/arm/boot/dts/rk3036-evb.dtb: clock-controller@20000000: 'clocks' >> is a dependency of 'assigned-clocks' > > 'clocks' is not a dependency of 'assigned-clocks'. The dt-schema should > be fixed to remove that requirement. If the driver does not have any clock inputs ("clocks" property), why does it care about some clock frequencies and parents? The clocks is the logical dependency of assigned-clocks, because otherwise hardware description is not complete. What should be here for Rockhip? We had similar cases like this for many drivers, I was fixing some of Exynos as well. In my case usually the root/external clock was missing, so I supplied is as input clock to the clock controller. Best regards, Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9CE92C433EF for ; Fri, 25 Mar 2022 07:32:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wsAql8uxkFCcWVM3mwqoyiV8ZntqKyr7bpRiUPfrXmo=; b=cpNBzh3TezMQJi yuljHI5kT9FfqkWOOE2s+v221LqrxDbFpXM5ZXcQTAq5QGlLzcdGn8ALQFAn6ZSDLg9HCJyqj0BvI GXtBwcZLyNcP3qQqRE4x0l/55ZIpQWaTAkzLct5rfc86it1L8QkKcvowoPtcTvOcbSXdzncEo06C0 CySVcwHE1PxE+bNtXoe7x+mL6qB890OdOD/rDCmzZ3aSVV2yJk9zfcLKPMVmCfmDyte+hMzkY0z73 SwF7OSG78IK1/z7f8mlcTDlCxS4xoXW6E9tQEl6DiHNyl5oUn8F41jj+lQkCzZ7ZkUPp7pb6ZFrWb 6Pi4mrNnuAMKRWgkuKqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXeQ1-001LU5-4v; Fri, 25 Mar 2022 07:31:33 +0000 Received: from mail-wm1-f50.google.com ([209.85.128.50]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nXePx-001LTV-Cc; Fri, 25 Mar 2022 07:31:30 +0000 Received: by mail-wm1-f50.google.com with SMTP id i67-20020a1c3b46000000b0038ce25c870dso380879wma.1; Fri, 25 Mar 2022 00:31:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=GuILc5kRDriiMUiIXV7yGyzOLFCBv5MwLQdIg/dr7Gg=; b=W8ad+geeroQ+Zd+eXxCQaLhCdYlvYyotHKAtrt5XHMIe8yU1MZQVQO1R6J8EEp+dwo 8lIBve08t3o1fuPmEFlMS2BL2RsR1L71XGpgxztmzF+H+SbBQNwqsLNktbCs7uV9Hjxy hMIkPpwLYH5I2VTOR6A+56oy97DmySycjpzdDNkuhckWEtJUAvOr/NQtyK29RKynfHMB 6stwO8iFEJGiFBL5RczDXwLDIIiKB8rI2lFP41PQE8lzZhpBFTNsR1KFcXLz8CYvP0oG XJuHnWIQuGIoSLXsxW/UNT/AvmaCiLFZL09zzOgZ65fEjE8unb7W9Rc+B7YRNkuoP7zO AMtQ== X-Gm-Message-State: AOAM532KAyKomvBHYcaHnaTopTXSUGzNLWwMPOjaqA7QpBJ3ERMImj95 U1TMaNkOkWNpc/TAdZFRWv0= X-Google-Smtp-Source: ABdhPJxX9+mei/tkczYkXDnJ8Ea8iol1WorIaCdEFNkBNxZcDCKU/ZfZR2wP0DOrgOPfGrPat8W3eA== X-Received: by 2002:a05:600c:3b86:b0:38c:afdf:66cd with SMTP id n6-20020a05600c3b8600b0038cafdf66cdmr17701222wms.198.1648193487331; Fri, 25 Mar 2022 00:31:27 -0700 (PDT) Received: from [192.168.0.158] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.googlemail.com with ESMTPSA id u7-20020a5d6da7000000b00203d9d1875bsm5199505wrs.73.2022.03.25.00.31.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Mar 2022 00:31:26 -0700 (PDT) Message-ID: Date: Fri, 25 Mar 2022 08:31:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH v1] dt-bindings: clock: convert rockchip, rk3188-cru.txt to YAML Content-Language: en-US To: Stephen Boyd , Johan Jonker , heiko@sntech.de Cc: robh+dt@kernel.org, krzk+dt@kernel.org, mturquette@baylibre.com, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220324133229.24035-1-jbx6244@gmail.com> <20220325005130.C45A3C340EC@smtp.kernel.org> From: Krzysztof Kozlowski In-Reply-To: <20220325005130.C45A3C340EC@smtp.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220325_003129_466808_5129BDA3 X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25/03/2022 01:51, Stephen Boyd wrote: > Quoting Johan Jonker (2022-03-24 12:51:36) >> Hi Heiko, Krzysztof, >> >> Question for the Rockchip clock maintainer: >> What clock should be used here and other SoCs with several clock parents >> in the tree? >> >> The clock.yaml produces a lot off notifications like: >> >> /arch/arm/boot/dts/rk3036-evb.dtb: clock-controller@20000000: 'clocks' >> is a dependency of 'assigned-clocks' > > 'clocks' is not a dependency of 'assigned-clocks'. The dt-schema should > be fixed to remove that requirement. If the driver does not have any clock inputs ("clocks" property), why does it care about some clock frequencies and parents? The clocks is the logical dependency of assigned-clocks, because otherwise hardware description is not complete. What should be here for Rockhip? We had similar cases like this for many drivers, I was fixing some of Exynos as well. In my case usually the root/external clock was missing, so I supplied is as input clock to the clock controller. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel