From: ygardi@codeaurora.org
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Yaniv Gardi <ygardi@codeaurora.org>,
james.bottomley@hansenpartnership.com,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
linux-scsi-owner@vger.kernel.org,
Raviv Shvili <rshvili@codeaurora.org>,
Vinayak Holikatti <vinholikatti@gmail.com>
Subject: Re: [PATCH v7 06/17] scsi: ufs: separate device and host quirks
Date: Thu, 10 Mar 2016 15:36:28 -0000 [thread overview]
Message-ID: <bf47e6fb4f534bf91bb11720c53266cf.squirrel@us.codeaurora.org> (raw)
In-Reply-To: <yq1r3fjqdq7.fsf@sermon.lab.mkp.net>
Martin,
the only way i can avoid the circular dependency is to
move the routines from ufs_quirks.c into ufshcd.c.
i will upload V8 soon
thanks,
Yaniv
>>>>>> "Yaniv" == Yaniv Gardi <ygardi@codeaurora.org> writes:
>
> Yaniv> Currently we use the host quirks mechanism in order to handle
> Yaniv> both device and host controller quirks. In order to support
> Yaniv> various of UFS devices we should separate handling the device
> Yaniv> quirks from the host controller's.
>
> This patch causes a circular dependency:
>
> depmod: ERROR: Cycle detected: ufshcd -> ufs_quirks -> ufshcd
>
> Please fix!
>
> --
> Martin K. Petersen Oracle Linux Engineering
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2016-03-10 15:36 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-08 12:35 [PATCH v7 00/17] add fixes, device quirks, error recovery, Yaniv Gardi
2016-03-08 12:35 ` [PATCH v7 01/17] scsi: ufs-qcom: add number of lanes per direction Yaniv Gardi
2016-03-08 12:35 ` Yaniv Gardi
2016-03-08 12:35 ` [PATCH v7 02/17] scsi: ufs: avoid spurious UFS host controller interrupts Yaniv Gardi
2016-03-08 12:35 ` [PATCH v7 03/17] scsi: ufs: implement scsi host timeout handler Yaniv Gardi
2016-03-08 13:01 ` Hannes Reinecke
2016-03-08 13:20 ` Hannes Reinecke
2016-03-08 19:58 ` ygardi
2016-03-09 6:44 ` Hannes Reinecke
2016-03-08 13:36 ` ygardi
2016-03-08 12:35 ` [PATCH v7 04/17] scsi: ufs: verify hba controller hce reg value Yaniv Gardi
2016-03-08 12:35 ` [PATCH v7 05/17] scsi: ufs: add support to read device and string descriptors Yaniv Gardi
2016-03-08 12:35 ` [PATCH v7 06/17] scsi: ufs: separate device and host quirks Yaniv Gardi
2016-03-10 2:16 ` Martin K. Petersen
2016-03-10 15:36 ` ygardi [this message]
2016-03-08 12:35 ` [PATCH v7 07/17] scsi: ufs: disable vccq if it's not needed by UFS device Yaniv Gardi
2016-03-08 12:35 ` [PATCH v7 08/17] scsi: ufs: make error handling bit faster Yaniv Gardi
2016-03-08 12:36 ` [PATCH v7 09/17] scsi: ufs: add error recovery after DL NAC error Yaniv Gardi
2016-03-08 12:36 ` [PATCH v7 10/17] scsi: ufs: add retry for query descriptors Yaniv Gardi
2016-03-08 12:36 ` [PATCH v7 11/17] scsi: ufs: handle non spec compliant bkops behaviour by device Yaniv Gardi
2016-03-08 12:36 ` [PATCH v7 12/17] scsi: ufs: tune UniPro parameters to optimize hibern8 exit time Yaniv Gardi
2016-03-08 12:36 ` [PATCH v7 13/17] scsi: ufs: fix leakage during link off state Yaniv Gardi
2016-03-08 12:36 ` [PATCH v7 14/17] scsi: ufs: add device quirk delay before putting UFS rails in LPM Yaniv Gardi
2016-03-08 12:36 ` [PATCH v7 15/17] scsi: ufs-qcom: set PA_Local_TX_LCC_Enable before link startup Yaniv Gardi
2016-03-08 13:02 ` Hannes Reinecke
2016-03-08 12:36 ` [PATCH v7 16/17] scsi: ufs-qcom: enable/disable the device ref clock Yaniv Gardi
2016-03-08 13:03 ` Hannes Reinecke
2016-03-08 12:36 ` [PATCH v7 17/17] scsi: ufs-qcom: add printouts of testbus debug registers Yaniv Gardi
2016-03-08 13:04 ` Hannes Reinecke
2016-03-08 13:04 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf47e6fb4f534bf91bb11720c53266cf.squirrel@us.codeaurora.org \
--to=ygardi@codeaurora.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=rshvili@codeaurora.org \
--cc=santoshsy@gmail.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.