From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1263C0015E for ; Tue, 25 Jul 2023 11:53:50 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F10661531; Tue, 25 Jul 2023 13:52:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F10661531 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1690286029; bh=wt30PyyiUGKguLZ/4q3Z0Vuj8Tz6MCttN0LhOD4lre0=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=tjUxnfuhwkStTnQOoPFfIP9uzyxge57zT41WV/9ZzAYHYa2VFN6RdtRZ/KiqGEQ4t bC4e/zRYDe7PHm4g14tQvaDBg5V5tkVM9fA6Cs86Ple1CLlNyyUBRFxeOnM5Oluv5C PN1kJrlD1Yg0EH2XCmppi+3p2cUqof4q9+JjP0AE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 86C8AF80571; Tue, 25 Jul 2023 13:51:46 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id C6D7DF80589; Tue, 25 Jul 2023 13:51:45 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 0E5D8F80163; Tue, 25 Jul 2023 12:04:27 +0200 (CEST) Received: from mblankhorst.nl (lankhorst.se [141.105.120.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 62B43F80149; Tue, 25 Jul 2023 12:04:21 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 62B43F80149 Message-ID: Date: Tue, 25 Jul 2023 12:04:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 4/9] ALSA: hda/i915: Allow xe as match for i915_component_master_match Content-Language: en-US To: Pierre-Louis Bossart , alsa-devel@alsa-project.org Cc: sound-open-firmware@alsa-project.org, linux-kernel@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , Cezary Rojewski , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Daniel Baluta References: <20230719164141.228073-1-maarten.lankhorst@linux.intel.com> <20230719164141.228073-5-maarten.lankhorst@linux.intel.com> <518bb7a9-3a85-2c13-68bf-63baaff176ef@linux.intel.com> From: Maarten Lankhorst In-Reply-To: <518bb7a9-3a85-2c13-68bf-63baaff176ef@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-MailFrom: maarten.lankhorst@linux.intel.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: GK2YQGJV3ZTW6MZUU5JPAZBLPQSPAPCZ X-Message-ID-Hash: GK2YQGJV3ZTW6MZUU5JPAZBLPQSPAPCZ X-Mailman-Approved-At: Tue, 25 Jul 2023 11:51:33 +0000 X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Hey, On 2023-07-24 12:28, Pierre-Louis Bossart wrote: > > > On 7/19/23 18:41, Maarten Lankhorst wrote: >> xe is a new driver for intel GPU's that shares the sound related code >> with i915. >> >> Don't allow it to be modprobed though; the module is not upstream yet >> and we should exclusively use the EPROBE_DEFER mechanism. > > I can't figure out what this comment means. > > how would the -EPROBE_DEFER mechanism help if the driver that will > trigger a new probe is not upstream? > > Not following at all what you intended to explain. What I mean is that there is code inside the current code that does request_module("i915"), the comment meant I didn't try to add any logic for request_module("xe"), as the driver is not merged yet. Additionally I am removing the request_module logic, but this comment was written when I first tried the simple solution of request_module("xe"). Turns out telepathy is hard, and using -EPROBE_DEFER is much simpler. :-) Cheers, ~Maarten