All of lore.kernel.org
 help / color / mirror / Atom feed
From: mturney@codeaurora.org
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org
Subject: Re: viability of dt-schema long-term
Date: Wed, 29 Sep 2021 17:08:41 -0700	[thread overview]
Message-ID: <bf523abba466af778c2e549806414578@codeaurora.org> (raw)
In-Reply-To: <CAL_JsqLuZkL6XztT_Wid3R_ohU01zQwU5HywqpN7hAS4fUNa=g@mail.gmail.com>

[sending to you directly because I am no longer on kernel list and you 
respond to the dtschema queries anyway, if you prefer I will re-join 
kernel list and re-send to whole list]

Reviving this thread now that we have some experience with dt-schema.

Our experience with both dtc and the dt-schema scripts is there doesn't 
seem to be any real distinction between errors and warnings.
Below are some examples.

This is from dt-validate: : pinctrl@f100000: 'width' is a required 
property
This is from dtc: : Warning (reg_format): /soc/pinctrl@f100000:reg: 
property has invalid length (8 bytes) (#address-cells == 2, #size-cells 
== 1)

In both cases neither tool returned an error code to the shell (echo $? 
= 0)
dtc will error with a syntax problem, but that seems to be it.

Is this how the kernel community prefers these tools to work?

Our concern is more with the dtschema scripts so we can use this to 
break the build and force the engineer to fix either the .yaml or .dtsi 
file.

Before we dive into the dtschema scripts we wanted to understand the 
philosophy behind the design decisions.


On 2020-11-30 11:02, Rob Herring wrote:
> On Wed, Nov 25, 2020 at 2:13 PM <mturney@codeaurora.org> wrote:
>> 
>> 
>> Folks,
>> I am advocating use of dt-schema project internally to validate DTS
>> files.
>> I should add that our use is outside kernel tree on proprietary 
>> project.
>> 
>> One of the push-backs I'm getting from the management chain is along 
>> the
>> lines of...
>> 
>> Who is this Rob Herring guy and why should we use a project that is 
>> only
>> sourced on https://github.com/robherring/dt-schema?
> 
> I wouldn't trust him...
> 
> That's the wrong repo though: 
> https://github.com/devicetree-org/dt-schema
> 
> (Unfortunately, GH's forks is misleading as the 'root' repo has 
> changed.)
> 
>> If the kernel project is using it, why isn't kernel.org hosting the
>> project?
> 
> It's not a kernel project. That's why devicetree.org hosts it.
> 
>> What is kernel plan if Rob walks away from the project, is this going 
>> to
>> wither away and die?
> 
> IMO, only if folks don't find validation valuable or a better
> implementation comes along.
> 
>> There are more, but the above pseudo-quotes grab the gist of the
>> management complaints.
>> 
>> Q.1) Is there a plan for the kernel project to suck dt-schema into its
>> orbit?
> 
> No, the 'plan' (more like desire) is more in the opposite direction.
> Move more of DT (bindings and dts files) out of the kernel for other
> projects to use. For now, we have the 'devicetree-rebasing' tree which
> is just the DT bits from the kernel tree.
> 
>> Q.2) How many active maintainers are there for dt-schema?
> 
> Mostly just me. Maxime Ripard is also one. Others could be if the need 
> arose.
> 
>> Q.3) How do I respond to the above types of complaints?
> 
> jsonschema python module which is our main dependency is also just a
> single maintainer. So is dtc. Maybe not what you want to highlight.
> 
> Rob

  reply	other threads:[~2021-09-30  0:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25 21:13 viability of dt-schema long-term mturney
2020-11-30 19:02 ` Rob Herring
2021-09-30  0:08   ` mturney [this message]
2021-10-01 14:32     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf523abba466af778c2e549806414578@codeaurora.org \
    --to=mturney@codeaurora.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.