Re: [PATCH v5 mptcp-next 0/4] mptcp: misc improvement

[Mat Martineau <martineau@kernel.org>]

On Fri, 22 Sep 2023, Paolo Abeni wrote:

> This series is a follow-up the discussion ongoing here:
>
> https://github.com/multipath-tcp/mptcp_net-next/issues/437
>
> Daire reported several sub-optimal MPTCP behaviour on high-latency
> links.
>
> At least 3 different items stands off:
>
> * notsent_lowat setting fooling the scheduler
> * sub-optimal send buffer autotuning
> * delayed acks being de-facto disabled due to subflow rcvlowat
>
> This series is an attempt to address the first 2 points above.
>
> v4 -> v5:
> - dealing with Mat feedback in patch 1/4 and 4/4
>

v5 LGTM, thanks Paolo!

Reviewed-by: Mat Martineau <martineau@kernel.org>

> v3 -> v4:
> - added patch 1/4, fixing a pre-existing issue related. That patch
>   should likely go via -net, included here because the issue can not
>   manifest itself until patch 4/4.
>   Despite by best attempt to test this, I thing it would be easier
>   to just lest syzkaller crunch it more than a bit.
>
> v2 -> v3:
> - avoid ingremental updates, always recompute sum(ssk->sndbuf) to avoid
>   drift on memory pressure/decrease
> - add some needed comments
>
> v1 -> v2:
> - fixed compiler warning in patch 3/3 && more local testing
>
> Paolo Abeni (4):
>  mptcp: fix delegated action races.
>  mptcp: consolidate sockopt synchronization
>  mptcp: ignore notsent_lowat setting at the subflow level.
>  mptcp: refactor sndbuf auto-tuning.
>
> net/mptcp/protocol.c | 48 +++++++++++++++---------
> net/mptcp/protocol.h | 89 ++++++++++++++++++++++++++++++--------------
> net/mptcp/sockopt.c  | 33 +++++-----------
> net/mptcp/subflow.c  | 31 ++++++++-------
> 4 files changed, 119 insertions(+), 82 deletions(-)
>
> -- 
> 2.41.0
>
>
>