From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E5C14C5DF97 for ; Wed, 26 Aug 2026 14:30:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wzEdz-0002HC-Ib; Wed, 26 Aug 2026 10:30:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wzEdx-00022x-DO; Wed, 26 Aug 2026 10:30:21 -0400 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wzEdv-0002cG-26; Wed, 26 Aug 2026 10:30:21 -0400 Received: from pps.filterd (m0360083.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67QE1WlJ4184882; Wed, 26 Aug 2026 14:30:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:reply-to:subject:to; s=pp1; bh=uNMnI+ixBzCpQX9zV/V3KpMMyeZwf0bos+r+embbRHQ=; b=BHbm4w9ZnzHg hUaL+z4HKC9mc0Y5IzF0Ec4NZZzegVdlgMAGNfRRxR8yPagGNgk5agVxxdKCWoFM /2GBaiRuZtMg15VN5b1ExRZLY9SPtAlffnzrQ9D0A0Zkbbsh4PkSlTUhV5jHE7en QiC+LkZgGmFPnp4+owvHInHl+eZP7bebYgzini4JAFfYBvNCaPkhow0TFdVIIsMR mVgkUYFLr65whF0Ix09PEwcmyUl3UzM/alL/po7YeNFysqkxvU5irYU1RK9FhxlL jWyS6Fx/Rxtyu5PsJDcgGjDqm61/MFf3d5ipOHGiFdASrzYeVBCZdbX507fRYaRf Ar8f24fYTw== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4g739478b3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Aug 2026 14:30:15 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 67QEQMfL011284; Wed, 26 Aug 2026 14:30:14 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4g7q3k2dmv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 26 Aug 2026 14:30:14 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 67QEUC1L13435524 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 26 Aug 2026 14:30:13 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CDF9158052; Wed, 26 Aug 2026 14:30:12 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 152915805D; Wed, 26 Aug 2026 14:30:12 +0000 (GMT) Received: from mambor8.rchland.ibm.com (unknown [9.10.239.198]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Wed, 26 Aug 2026 14:30:12 +0000 (GMT) Message-ID: Subject: Re: [PATCH v2 19/37] target/ppc: Refactor sleep and its variants to use a common helper From: Miles Glenn To: Chinmay Rath , qemu-devel@nongnu.org, qemu-ppc@nongnu.org, harshpb@linux.ibm.com Cc: npiggin@gmail.com, richard.henderson@linaro.org, vishalc@linux.ibm.com, tshah@linux.ibm.com, shivangu@linux.ibm.com, ojaswin@linux.ibm.com, aboorvad@linux.ibm.com, amachhiw@linux.ibm.com, shivani@linux.ibm.com, mkchauras@gmail.com, uverma@linux.ibm.com, nikhilks@linux.ibm.com Date: Wed, 26 Aug 2026 09:30:11 -0500 In-Reply-To: <20260826050923.74756-20-rathc@linux.ibm.com> References: <20260826050923.74756-1-rathc@linux.ibm.com> <20260826050923.74756-20-rathc@linux.ibm.com> Organization: IBM Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-27.el8_10) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Reinject: loops=2 maxloops=12 X-Proofpoint-GUID: yTLwbSy0yipreW8LSOCDogaHkXsX_P7X X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI2MDExNiBTYWx0ZWRfXxnUF2EWSldjg bJKgSvS51vcM/tcoeYpLj+66BfhD+10yjhXJJCGcc+Itzs63z8b9B/wGbQSK5b4ZYkmPRBgU/CX DXRaEIHNlFzdmKbLv41V4lFkrEhlAedgPQpsjCt6EegSMmEZadjdQUgOECE0NQfBg0tc2UJAQb/ iCzHnuI099TIIQAdJVVO7X5zEQp3+jWWCAqUoTDt4c0Umv+TfiPJg6Mrl2NY0CO4kBsqgHPQMB1 iOXbMNMVJxumT8LkQQrsxYWQ3AQItAeqV9IrgGqH5rO7no26wJiq0m7DBK5VcRahfb9cR2vDMb2 LaBhWw5xdOjWN5IGDu+MbchURqR0YF2zNvCKdcvS3PN/4i5tBrB4QYrkL1Di6Wwi0/sLVVIExW4 lWFPDTL5oHTfS9FHKLsBrX+pgzJZ3H0hSu28fUBSZjhA1pA0sYWuu+vmaxk3VMcYKVJfO/DB6bu kN4JBrWr26YSOpjbzvQ== X-Authority-Analysis: v=2.4 cv=Y/nIdBeN c=1 sm=1 tr=0 ts=6a8ef878 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=iQ6ETzBq9ecOQQE5vZCe:22 a=VnNF1IyMAAAA:8 a=Sh8xzq_NNK_JfPLPuzwA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Info: AW1haW4tMjYwODI2MDExNiBTYWx0ZWRfX3AvO7EutHWKv 00b/OCkVhR40LiG/27EcDn7a2/AtSgoWONlfaNGNoAIUsc2K89/JGfKkbCF9SQsiXpRKbrYW7Su T0lP++hPs5wNbyZDHkrYCMFtGD2aRrM= X-Proofpoint-ORIG-GUID: pQaQ91oiaNvAV_Ab4i8ZN8x0FNbobbug X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-26_04,2026-08-26_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 priorityscore=1501 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608260116 Received-SPF: pass client-ip=148.163.156.1; envelope-from=milesg@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: milesg@linux.ibm.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Reviewed-by: Glenn Miles Thanks, Glenn On Wed, 2026-08-26 at 10:38 +0530, Chinmay Rath wrote: > From: Ojaswin Mujoo > > With sleep, doze, nap, rvwinkle and stop instructions moved to > decodetree, the helper these instructions used : gen_helper_pminsn, > should now be renamed to gen_helper_PMINSN, abiding by the decodetree > standards. Do the same. > Also refactor their translation routine to use a common do_sleep routine > since they share majority of the code. > > Signed-off-by: Ojaswin Mujoo > Signed-off-by: Chinmay Rath > --- > target/ppc/helper.h | 2 +- > target/ppc/tcg-excp_helper.c | 2 +- > .../ppc/translate/processor-ctrl-impl.c.inc | 99 +++---------------- > 3 files changed, 16 insertions(+), 87 deletions(-) > > diff --git a/target/ppc/helper.h b/target/ppc/helper.h > index cd2a0948a3..7e15676122 100644 > --- a/target/ppc/helper.h > +++ b/target/ppc/helper.h > @@ -18,7 +18,7 @@ DEF_HELPER_1(rfdi, void, env) > DEF_HELPER_1(rfmci, void, env) > #if defined(TARGET_PPC64) > DEF_HELPER_2(scv, noreturn, env, i32) > -DEF_HELPER_2(pminsn, void, env, i32) > +DEF_HELPER_2(PMINSN, void, env, i32) > DEF_HELPER_1(rfid, void, env) > DEF_HELPER_1(rfscv, void, env) > DEF_HELPER_1(hrfid, void, env) > diff --git a/target/ppc/tcg-excp_helper.c b/target/ppc/tcg-excp_helper.c > index b04f07a637..c4ffa2dfbb 100644 > --- a/target/ppc/tcg-excp_helper.c > +++ b/target/ppc/tcg-excp_helper.c > @@ -459,7 +459,7 @@ void helper_scv(CPUPPCState *env, uint32_t lev) > } > } > > -void helper_pminsn(CPUPPCState *env, uint32_t insn) > +void helper_PMINSN(CPUPPCState *env, uint32_t insn) > { > CPUState *cs = env_cpu(env); > > diff --git a/target/ppc/translate/processor-ctrl-impl.c.inc b/target/ppc/translate/processor-ctrl-impl.c.inc > index bdbc195294..3b3ed3019a 100644 > --- a/target/ppc/translate/processor-ctrl-impl.c.inc > +++ b/target/ppc/translate/processor-ctrl-impl.c.inc > @@ -104,103 +104,32 @@ static bool trans_MSGSYNC(DisasContext *ctx, arg_MSGSYNC *a) > return true; > } > > -static bool do_doze(DisasContext *ctx, arg_DOZE *a) > -{ > - REQUIRE_64BIT(ctx); > - > -#if defined(CONFIG_USER_ONLY) > - gen_priv_opc(ctx); > -#else > - TCGv_i32 t; > - > - REQUIRE_HV(ctx); > - translator_io_start(&ctx->base); > - t = tcg_constant_i32(PPC_PM_DOZE); > - gen_helper_pminsn(tcg_env, t); > - /* Stop translation, as the CPU is supposed to sleep from now */ > - gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > -#endif /* defined(CONFIG_USER_ONLY) */ > - > - return true; > -} > -TRANS_FLAGS2(PM_ISA206, DOZE, do_doze); > - > -static bool do_nap(DisasContext *ctx, arg_NAP *a) > -{ > - REQUIRE_64BIT(ctx); > - > -#if defined(CONFIG_USER_ONLY) > - gen_priv_opc(ctx); > -#else > - TCGv_i32 t; > - > - REQUIRE_HV(ctx); > - translator_io_start(&ctx->base); > - t = tcg_constant_i32(PPC_PM_NAP); > - gen_helper_pminsn(tcg_env, t); > - /* Stop translation, as the CPU is supposed to sleep from now */ > - gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > -#endif /* defined(CONFIG_USER_ONLY) */ > - return true; > -} > -TRANS_FLAGS2(PM_ISA206, NAP, do_nap); > - > -static bool do_sleep(DisasContext *ctx, arg_SLEEP *a) > -{ > - REQUIRE_64BIT(ctx); > - > -#if defined(CONFIG_USER_ONLY) > - gen_priv_opc(ctx); > -#else > - TCGv_i32 t; > - > - REQUIRE_HV(ctx); > - translator_io_start(&ctx->base); > - t = tcg_constant_i32(PPC_PM_SLEEP); > - gen_helper_pminsn(tcg_env, t); > - /* Stop translation, as the CPU is supposed to sleep from now */ > - gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > -#endif /* defined(CONFIG_USER_ONLY) */ > - return true; > -} > -TRANS_FLAGS2(PM_ISA206, SLEEP, do_sleep); > - > -static bool do_rvwinkle(DisasContext *ctx, arg_RVWINKLE *a) > +/* > + * Helper to handle DOZE, NAP, SLEEP, RVWINKLE & STOP. Since none of them use > + * any arguments just use a placeholder arg_SLEEP. > + */ > +static bool do_sleep(DisasContext *ctx, arg_SLEEP *a, powerpc_pm_insn_t type) > { > REQUIRE_64BIT(ctx); > > #if defined(CONFIG_USER_ONLY) > gen_priv_opc(ctx); > -#else > +#elif defined(TARGET_PPC64) > TCGv_i32 t; > > REQUIRE_HV(ctx); > translator_io_start(&ctx->base); > - t = tcg_constant_i32(PPC_PM_RVWINKLE); > - gen_helper_pminsn(tcg_env, t); > + t = tcg_constant_i32(type); > + gen_helper_PMINSN(tcg_env, t); > /* Stop translation, as the CPU is supposed to sleep from now */ > gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > -#endif /* defined(CONFIG_USER_ONLY) */ > - return true; > -} > -TRANS_FLAGS2(PM_ISA206, RVWINKLE, do_rvwinkle); > - > -static bool do_stop(DisasContext *ctx, arg_STOP *a) > -{ > - REQUIRE_64BIT(ctx); > - > -#if defined(CONFIG_USER_ONLY) > - gen_priv_opc(ctx); > #else > - TCGv_i32 t; > - > - REQUIRE_HV(ctx); > - translator_io_start(&ctx->base); > - t = tcg_constant_i32(PPC_PM_STOP); > - gen_helper_pminsn(tcg_env, t); > - /* Stop translation, as the CPU is supposed to sleep from now */ > - gen_exception_nip(ctx, EXCP_HLT, ctx->base.pc_next); > + qemu_build_not_reached(); > #endif > return true; > } > -TRANS_FLAGS2(ISA300, STOP, do_stop); > +TRANS_FLAGS2(PM_ISA206, DOZE, do_sleep, PPC_PM_DOZE); > +TRANS_FLAGS2(PM_ISA206, NAP, do_sleep, PPC_PM_NAP); > +TRANS_FLAGS2(PM_ISA206, SLEEP, do_sleep, PPC_PM_SLEEP); > +TRANS_FLAGS2(PM_ISA206, RVWINKLE, do_sleep, PPC_PM_RVWINKLE); > +TRANS_FLAGS2(ISA300, STOP, do_sleep, PPC_PM_STOP);