From: Martin KaFai Lau <martin.lau@linux.dev>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, revest@google.com,
syzbot+cca39e6e84a367a7e6f6@syzkaller.appspotmail.com,
alexei.starovoitov@gmail.com,
Michal Switala <michal.switala@infogain.com>
Subject: Re: [PATCH] bpf: Ensure BPF programs testing skb context initialization
Date: Wed, 17 Jul 2024 12:16:16 -0700 [thread overview]
Message-ID: <bf687c6d-50ae-4252-9861-3e58f82f42f9@linux.dev> (raw)
In-Reply-To: <87y160407o.fsf@toke.dk>
On 7/17/24 6:28 AM, Toke Høiland-Jørgensen wrote:
>> It looks very similar to
>> https://lore.kernel.org/bpf/000000000000f6531b061494e696@google.com/. It has
>> been fixed in commit 5bcf0dcbf906 ("xdp: use flags field to disambiguate
>> broadcast redirect")
>>
>> I tried the C repro. I can reproduce in the bpf tree also which should have the
>> fix. I cannot reproduce in the bpf-next though.
>>
>> Cc Toke who knows more details here.
>
> Hmm, yeah, it does look kinda similar. Do you mean that the C repro from
> this new report triggers the crash for you on the current -bpf tree?
I was able to repro in bpf tree ~two days ago but not now. The bpf tree has been
fast forwarded and has the 6.10 changes. I just tried linux-stable/linux-6.9.y
which has the fix in the commit 5bcf0dcbf906. The syzbot report (against the
36534d3c5453) also has that fix.
In particular, the syzbot repro I tried:
https://syzkaller.appspot.com/text?tag=ReproC&x=17caa30a980000
prev parent reply other threads:[~2024-07-17 19:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 8:46 [PATCH] bpf: Ensure BPF programs testing skb context initialization Michal Switala
2024-07-10 18:38 ` Alexei Starovoitov
2024-07-15 18:13 ` Michal Switala
2024-07-15 21:59 ` Martin KaFai Lau
2024-07-17 13:28 ` Toke Høiland-Jørgensen
2024-07-17 19:16 ` Martin KaFai Lau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf687c6d-50ae-4252-9861-3e58f82f42f9@linux.dev \
--to=martin.lau@linux.dev \
--cc=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.switala@infogain.com \
--cc=netdev@vger.kernel.org \
--cc=revest@google.com \
--cc=syzbot+cca39e6e84a367a7e6f6@syzkaller.appspotmail.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.