All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: "Hogander, Jouni" <jouni.hogander@intel.com>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Cc: "ville.syrjala@linux.intel.com" <ville.syrjala@linux.intel.com>,
	"Kandpal,  Suraj" <suraj.kandpal@intel.com>
Subject: Re: [PATCH 01/20] drm/i915/hdmi: use generic poll_timeout_us() instead of __wait_for()
Date: Thu, 04 Sep 2025 14:26:49 +0300	[thread overview]
Message-ID: <bf70d39d8626ef5a428e237ee6bcc6dd5accff52@intel.com> (raw)
In-Reply-To: <ccdc9ebcff65a1a46305fb014ec78a35ee4c5b7f.camel@intel.com>

On Wed, 03 Sep 2025, "Hogander, Jouni" <jouni.hogander@intel.com> wrote:
> On Thu, 2025-08-28 at 15:20 +0300, Jani Nikula wrote:
>> Prefer generic poll helpers over i915 custom helpers.
>> 
>> The functional change is losing the exponentially growing sleep of
>> __wait_for(), which used to be 1, 2, 4, and 8 ms in this particular
>> case.
>> 
>> Use an arbitrary constant 4 ms sleep instead. The timeout remains,
>> varying between 20 ms and 3000 ms.
>> 
>> Cc: Suraj Kandpal <suraj.kandpal@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Jouni Högander <jouni.hogander@intel.com>

Thanks a lot for the review, series pushed to din.

BR,
Jani.

-- 
Jani Nikula, Intel

  reply	other threads:[~2025-09-04 11:26 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-28 12:20 [PATCH 00/20] drm/i915/display: convert to generic poll_timeout_us() Jani Nikula
2025-08-28 12:20 ` [PATCH 01/20] drm/i915/hdmi: use generic poll_timeout_us() instead of __wait_for() Jani Nikula
2025-09-03 13:29   ` Hogander, Jouni
2025-09-04 11:26     ` Jani Nikula [this message]
2025-08-28 12:20 ` [PATCH 02/20] drm/i915/hdcp: " Jani Nikula
2025-09-03 13:42   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 03/20] drm/i915/hdcp: use generic poll_timeout_us() instead of wait_for() Jani Nikula
2025-09-04  4:14   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 04/20] drm/i915/dsi: use generic poll_timeout_us() instead of wait_for_us() Jani Nikula
2025-09-04  4:27   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 05/20] drm/i915/dsi-pll: use generic poll_timeout_us() instead of wait_for() Jani Nikula
2025-09-04  4:34   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 06/20] drm/i915/gmbus: use generic poll_timeout*() instead of wait_for*() Jani Nikula
2025-09-04  4:53   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 07/20] drm/i915/wm: use generic poll_timeout_us() instead of wait_for() Jani Nikula
2025-09-04  5:01   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 08/20] drm/i915/cdclk: " Jani Nikula
2025-09-04  5:45   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 09/20] drm/i915/power: " Jani Nikula
2025-09-04  5:47   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 10/20] drm/i915/power-well: use generic poll_timeout_us() instead of wait_for() for DKL PHY Jani Nikula
2025-09-04  5:48   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 11/20] drm/i915/power-well: use generic poll_timeout_us() instead of wait_for() for VLV/CHV Jani Nikula
2025-09-04  5:54   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 12/20] drm/i915/dp: use generic poll_timeout_us() instead of wait_for() Jani Nikula
2025-09-04  6:08   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 13/20] drm/i915/dp: use generic poll_timeout_us() instead of wait_for() in link training Jani Nikula
2025-09-04  6:15   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 14/20] drm/i915/vblank: use generic poll_timeout_us() instead of wait_for() Jani Nikula
2025-09-04  8:05   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 15/20] drm/i915/tc: " Jani Nikula
2025-09-04  8:41   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 16/20] drm/i915/dsb: " Jani Nikula
2025-09-04  8:42   ` Hogander, Jouni
2025-08-28 12:20 ` [PATCH 17/20] drm/i915/lspcon: " Jani Nikula
2025-09-04  8:47   ` Hogander, Jouni
2025-08-28 12:21 ` [PATCH 18/20] drm/i915/opregion: " Jani Nikula
2025-09-04  9:06   ` Hogander, Jouni
2025-08-28 12:21 ` [PATCH 19/20] drm/i915/ddi: prefer poll_timeout_us() over readx_poll_timeout() Jani Nikula
2025-09-04  9:19   ` Hogander, Jouni
2025-08-28 12:21 ` [PATCH 20/20] drm/i915/pps: prefer poll_timeout_us() over read_poll_timeout() Jani Nikula
2025-09-04 10:23   ` Hogander, Jouni
2025-08-28 15:48 ` ✗ CI.checkpatch: warning for drm/i915/display: convert to generic poll_timeout_us() Patchwork
2025-08-28 15:49 ` ✓ CI.KUnit: success " Patchwork
2025-08-28 16:05 ` ✗ CI.checksparse: warning " Patchwork
2025-08-28 16:29 ` ✓ Xe.CI.BAT: success " Patchwork
2025-08-28 17:44 ` ✓ i915.CI.BAT: " Patchwork
2025-08-28 21:01 ` ✓ Xe.CI.Full: " Patchwork
2025-08-29  0:27 ` ✗ i915.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bf70d39d8626ef5a428e237ee6bcc6dd5accff52@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    --cc=suraj.kandpal@intel.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.