Re: [PATCH] Add room for insn-enconding and symbol name

[Danilo Krummrich <dakr@redhat.com>]

Hi,

On 5/8/24 13:58, Danilo Krummrich wrote:
> On 4/14/24 20:09, Sergio González Collado wrote:
>> The longest length of a symbol (KSYM_NAME_LEN) was increased to 512
>> in the reference [1]. This patch adds room for insn-encoding and a
>> symbol name, as proposed in [2]
>>
>> [1] https://lore.kernel.org/lkml/20220802015052.10452-6-ojeda@kernel.org/
>> [2] https://lore.kernel.org/lkml/16641a56-9139-4396-a5a8-89606bedd1f1@app.fastmail.com/
>>
>> Signed-off-by: Sergio González Collado <sergio.collado@gmail.com>

What's the status on this one? Are there any concerns or can we land this?

- Danilo

> 
> Acked-by: Danilo Krummrich <dakr@redhat.com>
> 
>> ---
>>   arch/x86/tools/insn_decoder_test.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/x86/tools/insn_decoder_test.c b/arch/x86/tools/insn_decoder_test.c
>> index 472540aeabc2..add51bfc2260 100644
>> --- a/arch/x86/tools/insn_decoder_test.c
>> +++ b/arch/x86/tools/insn_decoder_test.c
>> @@ -10,6 +10,7 @@
>>   #include <assert.h>
>>   #include <unistd.h>
>>   #include <stdarg.h>
>> +#include <linux/kallsym.h>
>>   #define unlikely(cond) (cond)
>> @@ -106,7 +107,7 @@ static void parse_args(int argc, char **argv)
>>       }
>>   }
>> -#define BUFSIZE 256
>> +#define BUFSIZE (256 + KSYM_NAME_LEN)
>>   int main(int argc, char **argv)
>>   {