Re: [OE-core] [PATCH 2/3] ovmf: drop gcc-12 specific BUILD_CFLAGS setting

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi João,

On 5/11/26 3:40 PM, Joao Marcos Costa wrote:
> Hello,
> 
> On 5/11/26 15:27, Quentin Schulz via lists.openembedded.org wrote:
>> Hi João,
>>
>> On 5/11/26 11:29 AM, João Marcos Costa wrote:
>>> This was handled upstream a while ago:
>>>
>>> https://eur02.safelinks.protection.outlook.com/? 
>>> url=https%3A%2F%2Fgithub.com%2Ftianocore%2Fedk2%2Fblob%2Fmaster%2FBaseTools%2FSource%2FC%2FDevicePath%2FGNUmakefile%23L27&data=05%7C02%7Cquentin.schulz%40cherry.de%7Cd69acb4606d94a43ff0b08deaf62e1b9%7C5e0e1b5221b54e7b83bb514ec460677e%7C0%7C0%7C639141036395687030%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=D5wD6%2Bvq%2BYJP3wUROtdEswwwc4RJFYmYvt7GLzsvJbo%3D&reserved=0
>>>
>>
>> It's not because upstream supports it that the version we're building 
>> has it, so pointing at a commit and mentioning it's part of the 
>> version we're building would be nice.
>>
>> 22130dcd98b4 ("Basetools: turn off gcc12 warning") part of edk2- 
>> stable202205 tag (and also edk2-stable202511 which we currently are at.
> 
> That's very much true. I will stick with this approach for the next time.
> 
>> Also, unclear whether this single file is the only place this flag 
>> being set would be enough as the flag was set globally and now it's 
>> only in a specific file within edk2 source code.
>>
>> Cheers,
>> Quentin
> 
> In any case, the warnings/errors would have been noticed during the 
> build if this flag was still needed (and missing).
> 

Not necessarily true as I don't think we build GCC for native recipes 
(and ovmf has a native variant), so it depends on the GCC on the host 
(unless you have uninative?). I don't know the autobuilder 
infrastructure, e.g. whether we build patches on multiple workers on 
different distros to have a big GCC version test matrix.

But yes, building with a newer GCC will generally not make warnings from 
previous versions disappear and I'm hoping upstream has had time to fix 
warnings returned by GCC12 in the last 4 years :)

Cheers,
Quentin