From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BCFEC4332F for ; Thu, 14 Dec 2023 11:38:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1444048AbjLNLiM (ORCPT ); Thu, 14 Dec 2023 06:38:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1444027AbjLNLiG (ORCPT ); Thu, 14 Dec 2023 06:38:06 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 5FE5CB7 for ; Thu, 14 Dec 2023 03:38:13 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B35ECC15; Thu, 14 Dec 2023 03:38:58 -0800 (PST) Received: from [10.1.197.60] (eglon.cambridge.arm.com [10.1.197.60]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7581F3F738; Thu, 14 Dec 2023 03:38:10 -0800 (PST) Message-ID: Date: Thu, 14 Dec 2023 11:38:08 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 16/24] x86/resctrl: Make resctrl_mounted checks explicit Content-Language: en-GB To: babu.moger@amd.com, x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com References: <20231025180345.28061-1-james.morse@arm.com> <20231025180345.28061-17-james.morse@arm.com> <7e611640-9e7a-42a1-b0d7-f8b76999e9b2@amd.com> From: James Morse In-Reply-To: <7e611640-9e7a-42a1-b0d7-f8b76999e9b2@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Babu, On 09/11/2023 20:47, Moger, Babu wrote: > On 10/25/23 13:03, James Morse wrote: >> The rdt_enable_key is switched when resctrl is mounted, and used to >> prevent a second mount of the filesystem. It also enables the >> architecture's context switch code. >> >> This requires another architecture to have the same set of static-keys, >> as resctrl depends on them too. The existing users of these static-keys >> are implicitly also checking if the filesystem is mounted. >> >> Make the resctrl_mounted checks explicit: resctrl can keep track of >> whether it has been mounted once. This doesn't need to be combined with >> whether the arch code is context switching the CLOSID. >> >> rdt_mon_enable_key is never used just to test that resctrl is mounted, >> but does also have this implication. Add a resctrl_mounted to all uses >> of rdt_mon_enable_key. This will allow rdt_mon_enable_key to be swapped >> with a helper in a subsequent patch. >> >> This will allow the static-key changing to be moved behind resctrl_arch_ >> calls. > Reviewed-by: Babu Moger Thanks! James