Re: [PATCH 5/5] tests/functional: Introduce a bletchley machine test

[Thomas Huth <thuth@redhat.com>]

On 29/01/2025 08.18, Cédric Le Goater wrote:
> Use do_test_arm_aspeed_openbmc() to run the latest OpenBMC firmware
> build of the bletchley BMC.
> 
> Signed-off-by: Cédric Le Goater <clg@redhat.com>
> ---
>   tests/functional/meson.build                  |  2 ++
>   tests/functional/test_arm_aspeed_bletchley.py | 24 +++++++++++++++++++
>   2 files changed, 26 insertions(+)
>   create mode 100755 tests/functional/test_arm_aspeed_bletchley.py
> 
> diff --git a/tests/functional/meson.build b/tests/functional/meson.build
> index 5c782ceb0a98..a8eb9c9a7af5 100644
> --- a/tests/functional/meson.build
> +++ b/tests/functional/meson.build
> @@ -25,6 +25,7 @@ test_timeouts = {
>     'arm_aspeed_witherspoon' : 120,
>     'arm_aspeed_ast2500' : 480,
>     'arm_aspeed_ast2600' : 720,
> +  'arm_aspeed_bletchley' : 120,
>     'arm_aspeed_rainier' : 240,
>     'arm_bpim2u' : 500,
>     'arm_collie' : 180,
> @@ -86,6 +87,7 @@ tests_arm_system_thorough = [
>     'arm_aspeed_witherspoon',
>     'arm_aspeed_ast2500',
>     'arm_aspeed_ast2600',
> +  'arm_aspeed_bletchley',
>     'arm_aspeed_rainier',
>     'arm_bpim2u',
>     'arm_canona1100',
> diff --git a/tests/functional/test_arm_aspeed_bletchley.py b/tests/functional/test_arm_aspeed_bletchley.py
> new file mode 100755
> index 000000000000..10e6703b53cb
> --- /dev/null
> +++ b/tests/functional/test_arm_aspeed_bletchley.py
> @@ -0,0 +1,24 @@
> +#!/usr/bin/env python3
> +#
> +# Functional test that boots the ASPEED machines
> +#
> +# SPDX-License-Identifier: GPL-2.0-or-later
> +
> +from qemu_test import Asset
> +from aspeed import AspeedTest
> +
> +class BletchleyMachine(AspeedTest):
> +
> +    ASSET_BLETCHLEY_FLASH = Asset(
> +        'https://github.com/legoater/qemu-aspeed-boot/raw/master/images/bletchley-bmc/openbmc-20250128071329/obmc-phosphor-image-bletchley-20250128071329.static.mtd.xz',
> +        'db21d04d47d7bb2a276f59d308614b4dfb70b9c7c81facbbca40a3977a2d8844');
> +
> +    def test_arm_ast2600_bletchley_openbmc(self):
> +        image_path = self.uncompress(self.ASSET_BLETCHLEY_FLASH)
> +
> +        self.do_test_arm_aspeed_openbmc('bletchley-bmc', image=image_path,
> +                                        uboot='2019.04', cpu_id='0xf00',
> +                                        soc='AST2600 rev A3');
> +
> +if __name__ == '__main__':
> +    AspeedTest.main()

Reviewed-by: Thomas Huth <thuth@redhat.com>