From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from saturn.retrosnub.co.uk ([178.18.118.26]:47773 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753968AbcIMRhT (ORCPT ); Tue, 13 Sep 2016 13:37:19 -0400 Subject: Re: [PATCH] iio: accel: sca3000_core: Fix superfluous indent white space To: Ico Doornekamp References: <20160909174414.31002-1-ico@pruts.nl> <95f27ba9-d54c-3dad-6b33-217010ce55bd@kernel.org> <1473522932-sup-4169@pruts.nl> <50ce9913-92cc-8e1b-f8eb-2faec769622a@kernel.org> <1473530764-sup-9251@pruts.nl> Cc: linux-iio From: Jonathan Cameron Message-ID: Date: Tue, 13 Sep 2016 18:37:17 +0100 MIME-Version: 1.0 In-Reply-To: <1473530764-sup-9251@pruts.nl> Content-Type: text/plain; charset=utf-8 Sender: linux-iio-owner@vger.kernel.org List-Id: linux-iio@vger.kernel.org On 10/09/16 19:16, Ico Doornekamp wrote: > * On 2016-09-10 18:26:45 +0200, Jonathan Cameron wrote: > >> Another good one is to find things in staging drivers that we now >> have IIO_INFO_* elements for. >> >> For example in sca3000 I see there is an explicit attribute defined that >> could be replaced by IIO_INFO_SAMPLING_FREQUENCY being added in the >> relevant masks and appropriate sections added to the read_raw >> and write_raw callbacks. >> >> Not a trivial job, but not too hard to figure out perhaps? > > Not too hard, although I'm not able to actually run and test due to lack > of hardware. That's fine. This one is my driver (rather needing some care and attention) and I have the hardware still. It's somewhat of a pain to fire up so I might do this one just on review but we'll see how busy I am at the weekend. > >> + a good step up from white space patches. > > I do hope the Little Penguin agrees on this :) Should do! > >> Guess maybe that needs to be a bit later if you are ploughing through >> the eudyptula-challenge (though that didn't exist when I got started >> so I don't know what order they do stuff in!) > > I have no clue: I'm trying to stick to the steps and not peek ahead. >