From: Markus Elfring <Markus.Elfring@web.de>
To: Johan Hovold <johan+linaro@kernel.org>,
linux-pci@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>
Cc: stable@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: Re: [PATCH 1/3] PCI/pwrctrl: Fix device leak at registration
Date: Tue, 22 Jul 2025 20:33:59 +0200 [thread overview]
Message-ID: <bf959b95-3e59-4863-bd92-84adee05f9e2@web.de> (raw)
In-Reply-To: <20250721153609.8611-2-johan+linaro@kernel.org>
…
> +++ b/drivers/pci/bus.c
> @@ -362,11 +362,15 @@ void pci_bus_add_device(struct pci_dev *dev)
…
> + if (of_pci_supply_present(dn)) {
> + if (!device_link_add(&dev->dev, &pdev->dev,
> + DL_FLAG_AUTOREMOVE_CONSUMER)) {
> + pci_err(dev, "failed to add device link to power control device %s\n",
> + pdev->name);
> + }
> + }
…
How do you think about to reconsider the usage of any curly brackets
once more?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.16-rc7#n197
Regards,
Markus
next prev parent reply other threads:[~2025-07-22 18:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-21 15:36 [PATCH 0/3] PCI/pwrctrl: Fix device and OF node leaks Johan Hovold
2025-07-21 15:36 ` [PATCH 1/3] PCI/pwrctrl: Fix device leak at registration Johan Hovold
2025-07-22 10:05 ` Jonathan Cameron
2025-07-22 12:00 ` Johan Hovold
2025-07-22 18:33 ` Markus Elfring [this message]
2025-07-21 15:36 ` [PATCH 2/3] PCI/pwrctrl: Fix device and OF node leak at bus scan Johan Hovold
2025-07-22 10:08 ` Jonathan Cameron
2025-07-22 12:04 ` Johan Hovold
2025-07-21 15:36 ` [PATCH 3/3] PCI/pwrctrl: Fix device leak at device stop Johan Hovold
2025-07-23 16:18 ` [PATCH 0/3] PCI/pwrctrl: Fix device and OF node leaks Manivannan Sadhasivam
2025-08-27 9:49 ` Johan Hovold
2025-08-27 19:35 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf959b95-3e59-4863-bd92-84adee05f9e2@web.de \
--to=markus.elfring@web.de \
--cc=Jonathan.Cameron@huawei.com \
--cc=bhelgaas@google.com \
--cc=johan+linaro@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mani@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.