From: Martin KaFai Lau <martin.lau@linux.dev>
To: "D. Wythe" <alibuda@linux.alibaba.com>
Cc: kgraul@linux.ibm.com, wenjia@linux.ibm.com, jaka@linux.ibm.com,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
pabeni@redhat.com, song@kernel.org, sdf@google.com,
haoluo@google.com, yhs@fb.com, edumazet@google.com,
john.fastabend@gmail.com, kpsingh@kernel.org, jolsa@kernel.org,
guwen@linux.alibaba.com, kuba@kernel.org, davem@davemloft.net,
netdev@vger.kernel.org, linux-s390@vger.kernel.org,
linux-rdma@vger.kernel.org, bpf@vger.kernel.org
Subject: Re: [PATCH bpf-next v3 3/5] net/smc: bpf: register smc_ops info struct_ops
Date: Thu, 19 Dec 2024 14:48:12 -0800 [thread overview]
Message-ID: <bfa40af2-e726-477a-bab2-7abebfdd6384@linux.dev> (raw)
In-Reply-To: <20241218024422.23423-4-alibuda@linux.alibaba.com>
On 12/17/24 6:44 PM, D. Wythe wrote:
> +static int smc_bpf_ops_check_member(const struct btf_type *t,
> + const struct btf_member *member,
> + const struct bpf_prog *prog)
> +{
> + u32 moff = __btf_member_bit_offset(t, member) / 8;
> +
> + switch (moff) {
> + case offsetof(struct smc_ops, name):
> + case offsetof(struct smc_ops, flags):
> + case offsetof(struct smc_ops, set_option):
> + case offsetof(struct smc_ops, set_option_cond):
> + break;
> + default:
> + return -EINVAL;
> + }
> +
> + return 0;
> +}
The whole smc_bpf_ops_check_member() should not be needed.
next prev parent reply other threads:[~2024-12-19 22:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 2:44 [PATCH bpf-next v3 0/5] net/smc: Introduce smc_ops D. Wythe
2024-12-18 2:44 ` [PATCH bpf-next v3 1/5] bpf: export necessary sympols for modules with struct_ops D. Wythe
2024-12-18 2:44 ` [PATCH bpf-next v3 2/5] net/smc: Introduce generic hook smc_ops D. Wythe
2024-12-18 2:44 ` [PATCH bpf-next v3 3/5] net/smc: bpf: register smc_ops info struct_ops D. Wythe
2024-12-19 22:48 ` Martin KaFai Lau [this message]
2024-12-23 2:00 ` D. Wythe
2024-12-26 19:44 ` Zhu Yanjun
2025-01-03 6:54 ` D. Wythe
2024-12-18 2:44 ` [PATCH bpf-next v3 4/5] libbpf: fix error when st-prefix_ops and ops from differ btf D. Wythe
2024-12-19 22:43 ` Martin KaFai Lau
2024-12-23 2:10 ` D. Wythe
2025-01-07 23:24 ` Martin KaFai Lau
2025-01-08 13:45 ` D. Wythe
2025-01-10 23:38 ` Andrii Nakryiko
2025-01-14 7:11 ` D. Wythe
2024-12-18 2:44 ` [PATCH bpf-next v3 5/5] bpf/selftests: add selftest for bpf_smc_ops D. Wythe
2024-12-19 22:59 ` Martin KaFai Lau
2024-12-23 2:03 ` D. Wythe
[not found] ` <bf1eef2ada1330c92b6326e90e23482e53a759fd40cd6c25832ae7f72207930a@mail.kernel.org>
[not found] ` <20241218043231.GA9245@j66a10360.sqa.eu95>
[not found] ` <1425b222-b5a5-4f18-a65b-af37226d099e@iogearbox.net>
[not found] ` <20241219040409.GA107394@j66a10360.sqa.eu95>
2024-12-19 5:23 ` [PATCH bpf-next v3 0/5] net/smc: Introduce smc_ops Daniel Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfa40af2-e726-477a-bab2-7abebfdd6384@linux.dev \
--to=martin.lau@linux.dev \
--cc=alibuda@linux.alibaba.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=haoluo@google.com \
--cc=jaka@linux.ibm.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kgraul@linux.ibm.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=wenjia@linux.ibm.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.