From: Krzysztof Kozlowski <krzk@kernel.org>
To: Sibi Sankar <sibi.sankar@oss.qualcomm.com>,
Gopikrishna Garmidi <gopikrishna.garmidi@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, rajendra.nayak@oss.qualcomm.com
Subject: Re: [PATCH] arm64: dts: qcom: Move board nodes to common DTSI
Date: Fri, 27 Mar 2026 07:45:34 +0100 [thread overview]
Message-ID: <bfb59eed-9f2b-4fa8-bc4f-99a86e2c26a0@kernel.org> (raw)
In-Reply-To: <328a120e-e9e0-4b3d-a2c0-04eb471c0937@oss.qualcomm.com>
On 26/03/2026 17:55, Sibi Sankar wrote:
>
> On 3/26/2026 7:55 PM, Krzysztof Kozlowski wrote:
>> On 26/03/2026 15:21, Gopikrishna Garmidi wrote:
>>> The display, peripherals (touchpad/touchscreen/keypad), usb and their
>>> dependent device nodes are common to both Glymur and Mahua CRDs,
>>> so move them from glymur-crd.dts to glymur-crd.dtsi to enable code
>>> reuse.
>>>
>> Same questions as for earlier tries (why this has to be repeated?), e.g.
>> x1-crd: Please describe here what is the actual common hardware. In
>> terms of physical hardware, not what you want to share.
>
>
> There seems to be some kind of confusion here. This patch doesn't
Indeed!
> introduce the common board file rather it just moves the nodes
> mentioned in the commit message to the common board file.
>
> https://lore.kernel.org/lkml/20260318124100.212992-3-gopikrishna.garmidi@oss.qualcomm.com/
The question stays. The common DTSI represented actual shared
motherboard design between these, so I would like to still see the
answers here. I just don't trust such commits because they mimic
downstream approach (and they were actually copying downstream in the past).
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-03-27 6:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-26 14:21 [PATCH] arm64: dts: qcom: Move board nodes to common DTSI Gopikrishna Garmidi
2026-03-26 14:25 ` Krzysztof Kozlowski
2026-03-26 16:55 ` Sibi Sankar
2026-03-27 6:45 ` Krzysztof Kozlowski [this message]
2026-03-27 12:46 ` Gopikrishna Garmidi
2026-03-29 10:57 ` Dmitry Baryshkov
2026-05-15 9:14 ` Pankaj Patil
2026-04-02 3:30 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfb59eed-9f2b-4fa8-bc4f-99a86e2c26a0@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gopikrishna.garmidi@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rajendra.nayak@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sibi.sankar@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.