From: Dinh Nguyen <dinguyen@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: socfpga: align SPI NOR node name with dtschema
Date: Thu, 7 Apr 2022 14:08:18 -0500 [thread overview]
Message-ID: <bfb8a830-4cd9-361b-e4db-a6d07dc1cbe0@kernel.org> (raw)
In-Reply-To: <20220407143049.294794-1-krzysztof.kozlowski@linaro.org>
On 4/7/22 09:30, Krzysztof Kozlowski wrote:
> The node names should be generic and SPI NOR dtschema expects "flash".
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dts | 2 +-
> arch/arm/boot/dts/socfpga_cyclone5_socdk.dts | 2 +-
> arch/arm/boot/dts/socfpga_cyclone5_sodia.dts | 2 +-
> arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts | 4 ++--
> 4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dts b/arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dts
> index 2a745522404d..11ccdc6c2dc6 100644
> --- a/arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dts
> +++ b/arch/arm/boot/dts/socfpga_arria10_socdk_qspi.dts
> @@ -9,7 +9,7 @@
> &qspi {
> status = "okay";
>
> - flash0: n25q00@0 {
> + flash0: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "micron,mt25qu02g", "jedec,spi-nor";
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
> index 253ef139181d..b2241205c7a9 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
> +++ b/arch/arm/boot/dts/socfpga_cyclone5_socdk.dts
> @@ -121,7 +121,7 @@ &mmc0 {
> &qspi {
> status = "okay";
>
> - flash0: n25q00@0 {
> + flash0: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "micron,mt25qu02g", "jedec,spi-nor";
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts b/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts
> index b0003f350e65..2564671fc1c6 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts
> +++ b/arch/arm/boot/dts/socfpga_cyclone5_sodia.dts
> @@ -113,7 +113,7 @@ &usb1 {
> &qspi {
> status = "okay";
>
> - flash0: n25q512a@0 {
> + flash0: flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "micron,n25q512a", "jedec,spi-nor";
> diff --git a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
> index 25874e1b9c82..f24f17c2f5ee 100644
> --- a/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
> +++ b/arch/arm/boot/dts/socfpga_cyclone5_vining_fpga.dts
> @@ -221,7 +221,7 @@ at24@50 {
> &qspi {
> status = "okay";
>
> - n25q128@0 {
> + flash@0 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "micron,n25q128", "jedec,spi-nor";
> @@ -238,7 +238,7 @@ n25q128@0 {
> cdns,tslch-ns = <4>;
> };
>
> - n25q00@1 {
> + flash@1 {
> #address-cells = <1>;
> #size-cells = <1>;
> compatible = "micron,mt25qu02g", "jedec,spi-nor";
Applied!
Thanks,
Dinh
prev parent reply other threads:[~2022-04-07 19:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 14:30 [PATCH] ARM: dts: socfpga: align SPI NOR node name with dtschema Krzysztof Kozlowski
2022-04-07 19:08 ` Dinh Nguyen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfb8a830-4cd9-361b-e4db-a6d07dc1cbe0@kernel.org \
--to=dinguyen@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.