From: duchangbin <changbin.du@huawei.com>
To: Namhyung Kim <namhyung@kernel.org>
Cc: duchangbin <changbin.du@huawei.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
"Arnaldo Carvalho de Melo" <acme@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Liang, Kan" <kan.liang@linux.intel.com>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"llvm@lists.linux.dev" <llvm@lists.linux.dev>
Subject: Re: [PATCH v3 2/4] perf: disasm: use build_id_path if fallback failed
Date: Tue, 25 Jun 2024 01:47:54 +0000 [thread overview]
Message-ID: <bfdcb5d8f0664f48a3d6be93954ebdb2@huawei.com> (raw)
In-Reply-To: <ZnoKcoHtjvJgjETL@google.com>
On Mon, Jun 24, 2024 at 05:08:18PM -0700, Namhyung Kim wrote:
> Hello,
>
> On Tue, Jun 18, 2024 at 09:55:28AM +0800, Changbin Du wrote:
> > If we can not fallback for special dso (vmlinx and vdso), use the
> > build_id_path found previously.
> >
> > To make change easy, this change first refactors the code by extracting
> > two functions read_buildid_linkname() and fallback_filename().
>
> Can you please split the refactoring from the actual change? It'd be
> easier to review and to maintain the code.
>
Sure, I'll do it taday.
> Thanks,
> Namhyung
>
--
Cheers,
Changbin Du
next prev parent reply other threads:[~2024-06-25 1:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 1:55 [PATCH v3 0/4] perf: support specify vdso path in cmdline Changbin Du
2024-06-18 1:55 ` [PATCH v3 1/4] " Changbin Du
2024-06-18 1:55 ` [PATCH v3 2/4] perf: disasm: use build_id_path if fallback failed Changbin Du
2024-06-25 0:08 ` Namhyung Kim
2024-06-25 1:47 ` duchangbin [this message]
2024-06-18 1:55 ` [PATCH v3 3/4] perf: symbol: generalize vmlinux path searching Changbin Du
2024-06-18 1:55 ` [PATCH v3 4/4] perf: symbol: try to seach vdso path if not given by user Changbin Du
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfdcb5d8f0664f48a3d6be93954ebdb2@huawei.com \
--to=changbin.du@huawei.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=jolsa@kernel.org \
--cc=justinstitt@google.com \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=namhyung@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.