All of lore.kernel.org
 help / color / mirror / Atom feed
From: "github-actions[bot]" <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/bluez] 4dc2b3: doc/hci-protocol: Fix missing & on mtu argument in...
Date: Thu, 03 Sep 2026 08:00:14 -0700	[thread overview]
Message-ID: <bluez/bluez/push/refs/heads/1157193/000000-dd7a28@github.com> (raw)

  Branch: refs/heads/1157193
  Home:   https://github.com/bluez/bluez
  Commit: 4dc2b34bf4ada36a7cd2ae77ee4da817457291f9
      https://github.com/bluez/bluez/commit/4dc2b34bf4ada36a7cd2ae77ee4da817457291f9
  Author: Zijun Hu <zijun.hu@oss.qualcomm.com>
  Date:   2026-09-03 (Thu, 03 Sep 2026)

  Changed paths:
    M doc/hci-protocol.rst

  Log Message:
  -----------
  doc/hci-protocol: Fix missing & on mtu argument in BT_RCVMTU example

getsockopt() requires a pointer argument, but mtu was passed by value.

Fix by using &mtu instead of mtu.


  Commit: f54ff046366829d150f63bbc10bb4afce69193b9
      https://github.com/bluez/bluez/commit/f54ff046366829d150f63bbc10bb4afce69193b9
  Author: Zijun Hu <zijun.hu@oss.qualcomm.com>
  Date:   2026-09-03 (Thu, 03 Sep 2026)

  Changed paths:
    M monitor/broadcom.c
    M monitor/broadcom.h
    M monitor/intel.c
    M monitor/intel.h
    M monitor/msft.c
    M monitor/msft.h
    M monitor/packet.c
    M monitor/vendor.c
    M monitor/vendor.h

  Log Message:
  -----------
  monitor: s/vendor_(evt|event)/\1_vendor/

Kernel include/net/bluetooth/hci.h defines:

  #define HCI_EVENT_PKT   0x04
  #define HCI_VENDOR_PKT  0xff
  #define HCI_EV_VENDOR   0xff

HCI_VENDOR_PKT and HCI_EV_VENDOR share the same value, but are very
different, as the table below shows:

+------------+-----------------------+---------------------------+
|            | HCI_VENDOR_PKT        | HCI_EV_VENDOR             |
+------------+-----------------------+---------------------------+
| Defined by | Vendor                | BT SIG                    |
+------------+-----------------------+---------------------------+
| Hierarchy  | Parallel to           | Nested inside             |
|            | HCI_EVENT_PKT         | HCI_EVENT_PKT             |
+------------+-----------------------+---------------------------+
| Direction  | RX and TX             | RX only                   |
+------------+-----------------------+---------------------------+
| kernel <-> | HCI_VENDOR_PKT, ...   | 0x04, HCI_EV_VENDOR, ...  |
| userspace  |                       |                           |
+------------+-----------------------+---------------------------+
| kernel <-> | RX: 23, vendor packet | RX: 3, HCI_EV_VENDOR, ... |
| monitor    | TX: 22, vendor packet |                           |
+------------+-----------------------+---------------------------+

monitor is about to gain HCI_VENDOR_PKT support. To avoid confusing the
two, rename what deals with HCI_EV_VENDOR to follow its pattern:

s/vendor_(evt|event)/\1_vendor/


  Commit: 186e847ea320de52b5324cbb9f02e9c1d01f6187
      https://github.com/bluez/bluez/commit/186e847ea320de52b5324cbb9f02e9c1d01f6187
  Author: Zijun Hu <zijun.hu@oss.qualcomm.com>
  Date:   2026-09-03 (Thu, 03 Sep 2026)

  Changed paths:
    M doc/hci-protocol.rst

  Log Message:
  -----------
  doc/hci-protocol: Add BT_RECV_VENDOR_PKT socket option for HCI_CHANNEL_USER

BT_RECV_VENDOR_PKT controls receiving vendor packets over HCI_CHANNEL_USER.

Disabled by default to avoid regressions for existing applications.


  Commit: dd7a28aebd5577709585647958d4d92357e58db4
      https://github.com/bluez/bluez/commit/dd7a28aebd5577709585647958d4d92357e58db4
  Author: Zijun Hu <zijun.hu@oss.qualcomm.com>
  Date:   2026-09-03 (Thu, 03 Sep 2026)

  Changed paths:
    M doc/btsnoop-protocol.rst
    M monitor/analyze.c
    M monitor/packet.c
    M monitor/packet.h
    M src/shared/btsnoop.h

  Log Message:
  -----------
  monitor: Support vendor packets

Kernel include/net/bluetooth/hci.h defines its packet type as:

  #define HCI_VENDOR_PKT  0xff

  - Defined by vendor
  - Bidirectional (RX and TX)
  - kernel <-> userspace: HCI_VENDOR_PKT followed by vendor packet
  - kernel <-> monitor: vendor packet has TX opcode (22) or RX
    opcode (23)

Support them in tool btmon.


Compare: https://github.com/bluez/bluez/compare/4dc2b34bf4ad%5E...dd7a28aebd55

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications

                 reply	other threads:[~2026-09-03 15:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bluez/bluez/push/refs/heads/1157193/000000-dd7a28@github.com \
    --to=noreply@github.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.