All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pauli Virtanen <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/bluez] 9a560b: mgmt-tester: ignore Debug feature in Read Exp Feat...
Date: Sun, 20 Sep 2026 14:50:59 -0700	[thread overview]
Message-ID: <bluez/bluez/push/refs/heads/1169895/000000-24a2c7@github.com> (raw)

  Branch: refs/heads/1169895
  Home:   https://github.com/bluez/bluez
  Commit: 9a560bf5f3f63eb07365dccfced7227688620a55
      https://github.com/bluez/bluez/commit/9a560bf5f3f63eb07365dccfced7227688620a55
  Author: Pauli Virtanen <pav@iki.fi>
  Date:   2026-09-20 (Sun, 20 Sep 2026)

  Changed paths:
    M test/functional/test_kernel_testers.py
    M tools/mgmt-tester.c

  Log Message:
  -----------
  mgmt-tester: ignore Debug feature in Read Exp Feature tests

CONFIG_BT_FEATURE_DEBUG controls whether Debug experimental feature is
present. mgmt-tester hardcodes one configuration.

CONFIG_BT_FEATURE_DEBUG is incompatible with DYNAMIC_DEBUG, so requiring
test configurations to have it enabled is inconvenient.

Instead, adjust test to accept either debug present or not.

Fixes failures in "Read Exp Feature - Success"


  Commit: 0a8a880e2113fc7b73b5fdd39bc7c1706431685b
      https://github.com/bluez/bluez/commit/0a8a880e2113fc7b73b5fdd39bc7c1706431685b
  Author: Pauli Virtanen <pav@iki.fi>
  Date:   2026-09-20 (Sun, 20 Sep 2026)

  Changed paths:
    M tools/mgmt-tester.c

  Log Message:
  -----------
  mgmt-tester: Fix expected status for invalid key entries

Kernel commit 1e9683c9b6ca ("Bluetooth: MGMT: Ignore keys being loaded
with invalid type") made Load Link Keys and Load Long Term Keys skip
entries with an invalid address type or initiator value instead of
rejecting the whole command with Invalid Parameters.

Update "Load Link Keys - Invalid Parameters 3" and "Load Long Term Keys
- Invalid Parameters 2 and 3" to expect success.

Assisted-by: opencode:qwen3.8-flash-next


  Commit: d9993216e9e0b3576eab2c119d8126e6008f44e4
      https://github.com/bluez/bluez/commit/d9993216e9e0b3576eab2c119d8126e6008f44e4
  Author: Pauli Virtanen <pav@iki.fi>
  Date:   2026-09-20 (Sun, 20 Sep 2026)

  Changed paths:
    M tools/mgmt-tester.c

  Log Message:
  -----------
  mgmt-tester: mark Pair Device - Power off 1 as fail_tolerant

The pending Pair Device command is completed by whichever path wins
the race against HCIDEVDOWN: if it is still queued when the controller
is closed, __mgmt_power_off() responds with Not Powered; if the
connection failure callbacks run first, pairing_complete_cb() responds
with Disconnected.

Both are valid outcomes, so mark the test fail_tolerant, as done for
Get Conn Info - Power off

Assisted-by: opencode:qwen3.8-flash-next


  Commit: 4ecbe91214e452c2e132a7953058e08934d19572
      https://github.com/bluez/bluez/commit/4ecbe91214e452c2e132a7953058e08934d19572
  Author: Pauli Virtanen <pav@iki.fi>
  Date:   2026-09-20 (Sun, 20 Sep 2026)

  Changed paths:
    M tools/mgmt-tester.c

  Log Message:
  -----------
  mgmt-tester: Report unexpected status as test failure

command_generic_callback() used tester_test_abort() when the command
status differed from the expected one, making the test result in
"Not Run" and hiding real failures from the summary. Treat such status
mismatches as a test failure, warning with both statuses. Mismatches
tolerated through fail_tolerant are unaffected.

Assisted-by: opencode:qwen3.8-flash-next


  Commit: 24a2c70dcbbb4202d654574aaa2f7c84b341fb29
      https://github.com/bluez/bluez/commit/24a2c70dcbbb4202d654574aaa2f7c84b341fb29
  Author: Pauli Virtanen <pav@iki.fi>
  Date:   2026-09-20 (Sun, 20 Sep 2026)

  Changed paths:
    M src/shared/tester.c

  Log Message:
  -----------
  shared/tester: Count setup failures as test failures

A test whose setup stage fails ends up as "Not Run", without counting as
a failure.

Make them count as TEST_RESULT_FAILED. Setup failures are real failures,
and should not be considered same as skipped tests.

Intentional skips through tester_pre_setup_abort() still report "Not
Run".

Assisted-by: opencode:qwen3.8-flash-next


Compare: https://github.com/bluez/bluez/compare/9a560bf5f3f6%5E...24a2c70dcbbb

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications

                 reply	other threads:[~2026-09-20 21:51 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bluez/bluez/push/refs/heads/1169895/000000-24a2c7@github.com \
    --to=noreply@github.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.