From: "github-actions[bot]" <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/bluez] e178b5: obexd: Pass at_(un)register value to logind callbacks
Date: Wed, 11 Jun 2025 06:20:18 -0700 [thread overview]
Message-ID: <bluez/bluez/push/refs/heads/970848/000000-223573@github.com> (raw)
Branch: refs/heads/970848
Home: https://github.com/bluez/bluez
Commit: e178b5cd7471c69ef34604355bb66adca26ab088
https://github.com/bluez/bluez/commit/e178b5cd7471c69ef34604355bb66adca26ab088
Author: Andrew Sayers <kernel.org@pileofstuff.org>
Date: 2025-06-11 (Wed, 11 Jun 2025)
Changed paths:
M obexd/client/pbap.c
M obexd/plugins/bluetooth.c
M obexd/src/logind.c
M obexd/src/logind.h
Log Message:
-----------
obexd: Pass at_(un)register value to logind callbacks
Logind (un)registers callbacks that it calls when the user's state changes.
Callbacks may also be called during (un)registration.
Clients may need to handle those initial/final calls specially.
Pass an argument indicating whether this is being called during
(un)registration, and modify existing callbacks to ignore that argument.
Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
Commit: b5815edd2703eb54edd0916fd44af8865255ad12
https://github.com/bluez/bluez/commit/b5815edd2703eb54edd0916fd44af8865255ad12
Author: Andrew Sayers <kernel.org@pileofstuff.org>
Date: 2025-06-11 (Wed, 11 Jun 2025)
Changed paths:
M obexd/client/pbap.c
Log Message:
-----------
pbap: use the public DBus connection
PBAP must not use its own private DBus connection, as it needs to
receive messages sent to the bus name of the public connection.
PBAP must not unregister itself when the program is exiting, as it might
cause a long delay. Unregistering at exit is redundant anyway, as the
service will be implicitly unregistered when the connection is closed.
But PBAP must unregister itself when the user becomes inactive mid-session,
so systems with multiple users logged in at once can share bluetooth.
Use the public DBus connection instead of a private one,
and explicitly unregister the profile if appropriate.
Thanks Pauli Virtanen for pointing out the exit issue:
https://lore.kernel.org/linux-bluetooth/ae15a9fa4bf0bd509dd3d44f1f364e241e50956c.camel@iki.fi/
Reported-by: Frédéric Danis <frederic.danis@collabora.com>
Closes: https://lore.kernel.org/linux-bluetooth/333ad76e-0aba-4f93-b141-8e69fb47535f@collabora.com/
Suggested-by: Pauli Virtanen <pav@iki.fi>
Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
Commit: 2235733264a4196f07882aa5398410bf169d4dc8
https://github.com/bluez/bluez/commit/2235733264a4196f07882aa5398410bf169d4dc8
Author: Andrew Sayers <kernel.org@pileofstuff.org>
Date: 2025-06-11 (Wed, 11 Jun 2025)
Changed paths:
M obexd/src/main.c
M obexd/src/obexd.h
Log Message:
-----------
Revert "obexd: Support creating private system/session bus connections"
This reverts commit 237d818ef294e22be87fba69b3cdd79c75c201e7,
which encouraged the use of private DBus connections.
Doing so caused a bug, so it's better to remove the temptation for now
and re-add it if a legitimate use case is ever found.
Signed-off-by: Andrew Sayers <kernel.org@pileofstuff.org>
Compare: https://github.com/bluez/bluez/compare/e178b5cd7471%5E...2235733264a4
To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications
reply other threads:[~2025-06-11 13:20 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bluez/bluez/push/refs/heads/970848/000000-223573@github.com \
--to=noreply@github.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.