All of lore.kernel.org
 help / color / mirror / Atom feed
From: Oliver Chang <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/bluez] bf5ec1: bap: remove bap_update_cigs callback properly whan...
Date: Mon, 11 Aug 2025 13:36:27 -0700	[thread overview]
Message-ID: <bluez/bluez/push/refs/heads/master/5ccbff-013b34@github.com> (raw)

  Branch: refs/heads/master
  Home:   https://github.com/bluez/bluez
  Commit: bf5ec167b66fc40f7c5f3abca58752fee0d4153b
      https://github.com/bluez/bluez/commit/bf5ec167b66fc40f7c5f3abca58752fee0d4153b
  Author: Pauli Virtanen <pav@iki.fi>
  Date:   2025-08-11 (Mon, 11 Aug 2025)

  Changed paths:
    M profiles/audio/bap.c

  Log Message:
  -----------
  bap: remove bap_update_cigs callback properly whan data is freed

setup_free() may re-enable the CIG update callback. If this occurs in
bap_data_free(), the callback crashes with UAF.

Fix by moving clearing the callback after all setups are freed.


  Commit: 013b3431c58d81e9e01dac7e8a5d088e357326a3
      https://github.com/bluez/bluez/commit/013b3431c58d81e9e01dac7e8a5d088e357326a3
  Author: Oliver Chang <ochang@google.com>
  Date:   2025-08-11 (Mon, 11 Aug 2025)

  Changed paths:
    M src/sdp-xml.c

  Log Message:
  -----------
  Fix buffer overflow in sdp_xml_parse_uuid128

This was found by OSS-Fuzz.

This can be reproduced by running this input:
`<uuid value="111111111111111111111111111111111111">`
against the harness in
https://github.com/google/oss-fuzz/blob/master/projects/bluez/fuzz_xml.c
which just calls `sdp_xml_parse_record`.

`sdp_xml_parse_uuid` checks that the length of the string is 36 (32
digits + 4 '-' characters) prior to calling `sdp_xml_parse_uuid128`.

There's no check preventing this data from being 36 digits (with no
"-"), which leads to a buffer overflow in sdp_xml_parse_uuid128.

https://issues.oss-fuzz.com/issues/42534847
https://oss-fuzz.com/testcase-detail/5070205940531200


Compare: https://github.com/bluez/bluez/compare/5ccbff0898fa...013b3431c58d

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications

                 reply	other threads:[~2025-08-11 20:36 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bluez/bluez/push/refs/heads/master/5ccbff-013b34@github.com \
    --to=noreply@github.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.