All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luiz Augusto von Dentz <noreply@github.com>
To: linux-bluetooth@vger.kernel.org
Subject: [bluez/bluez] acd0a4: tools/tester: Fix crash when hciemu_new fails
Date: Thu, 07 May 2026 10:00:13 -0700	[thread overview]
Message-ID: <bluez/bluez/push/refs/heads/master/e51115-e3dec6@github.com> (raw)

  Branch: refs/heads/master
  Home:   https://github.com/bluez/bluez
  Commit: acd0a49506a1a24a4fe532d77f6f5a1301b011bb
      https://github.com/bluez/bluez/commit/acd0a49506a1a24a4fe532d77f6f5a1301b011bb
  Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M tools/6lowpan-tester.c
    M tools/bnep-tester.c
    M tools/ioctl-tester.c
    M tools/iso-tester.c
    M tools/l2cap-tester.c
    M tools/mesh-tester.c
    M tools/mgmt-tester.c
    M tools/rfcomm-tester.c
    M tools/sco-tester.c
    M tools/smp-tester.c
    M tools/userchan-tester.c

  Log Message:
  -----------
  tools/tester: Fix crash when hciemu_new fails

When hciemu_new returns NULL, the mgmt object was not being unreferenced
before returning from the pre-setup failure path. This could lead to a
NULL dereference in read_info_callback when it later calls
hciemu_get_address on the NULL hciemu pointer.

Add mgmt_unref and return to the error path across all testers.


  Commit: a068db99c46f1fc34b1e2f315fd27b29eab0fee5
      https://github.com/bluez/bluez/commit/a068db99c46f1fc34b1e2f315fd27b29eab0fee5
  Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M emulator/hciemu.c
    M emulator/hciemu.h

  Log Message:
  -----------
  emulator/hciemu: Add hciemu_new_debug/hciemu_new_num_debug

Add new constructors that accept debug callback and user_data parameters,
setting them up immediately after allocation so errors during early
initialization (create_vhci, hciemu_client_new) are captured by the debug
output.


  Commit: e3dec62da2a5170f7c4f94d1eba567f30068f502
      https://github.com/bluez/bluez/commit/e3dec62da2a5170f7c4f94d1eba567f30068f502
  Author: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
  Date:   2026-05-06 (Wed, 06 May 2026)

  Changed paths:
    M tools/6lowpan-tester.c
    M tools/bnep-tester.c
    M tools/ioctl-tester.c
    M tools/iso-tester.c
    M tools/l2cap-tester.c
    M tools/mesh-tester.c
    M tools/mgmt-tester.c
    M tools/rfcomm-tester.c
    M tools/sco-tester.c
    M tools/smp-tester.c
    M tools/userchan-tester.c

  Log Message:
  -----------
  tools/tester: Retry with debug on hciemu_new failure

When hciemu_new fails, retry using hciemu_new_debug to capture early
initialization errors before reporting the failure. This helps diagnose
issues like vhci or client creation failures in CI.


Compare: https://github.com/bluez/bluez/compare/e51115ccd4df...e3dec62da2a5

To unsubscribe from these emails, change your notification settings at https://github.com/bluez/bluez/settings/notifications

                 reply	other threads:[~2026-05-07 17:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bluez/bluez/push/refs/heads/master/e51115-e3dec6@github.com \
    --to=noreply@github.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.