From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=r4HO=EI=vger.kernel.org=linux-kbuild-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,
	HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,
	USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B4F7DC388F2
	for <linux-kbuild@archiver.kernel.org>; Mon,  2 Nov 2020 14:32:25 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by mail.kernel.org (Postfix) with ESMTP id 78D0120731
	for <linux-kbuild@archiver.kernel.org>; Mon,  2 Nov 2020 14:32:25 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726070AbgKBOcZ (ORCPT
        <rfc822;linux-kbuild@archiver.kernel.org>);
        Mon, 2 Nov 2020 09:32:25 -0500
Received: from codesynthesis.com ([142.44.161.217]:46106 "EHLO
        codesynthesis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726076AbgKBOcY (ORCPT
        <rfc822;linux-kbuild@vger.kernel.org>);
        Mon, 2 Nov 2020 09:32:24 -0500
Received: from brak.codesynthesis.com (unknown [105.184.207.60])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by codesynthesis.com (Postfix) with ESMTPSA id 6D6A35F1DE;
        Mon,  2 Nov 2020 14:32:23 +0000 (UTC)
Received: by brak.codesynthesis.com (Postfix, from userid 1000)
        id 27D7A1A800C4; Mon,  2 Nov 2020 16:32:19 +0200 (SAST)
Date:   Mon, 2 Nov 2020 16:32:19 +0200
From:   Boris Kolpackov <boris@codesynthesis.com>
To:     Masahiro Yamada <masahiroy@kernel.org>
Cc:     Luis Chamberlain <mcgrof@kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH 2/2] kconfig: clean up header inclusion
Message-ID: <boris.20201102162336@codesynthesis.com>
References: <20201029155152.2467-1-boris@codesynthesis.com>
 <20201029155152.2467-3-boris@codesynthesis.com>
 <CAK7LNARRfK7LFrmJdMj4n77rb6pBYY=gXNLkfoSjk=pBJkg79w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAK7LNARRfK7LFrmJdMj4n77rb6pBYY=gXNLkfoSjk=pBJkg79w@mail.gmail.com>
Organization: Code Synthesis
User-Agent: Mutt/1.5.24 (2015-08-30)
Precedence: bulk
List-ID: <linux-kbuild.vger.kernel.org>
X-Mailing-List: linux-kbuild@vger.kernel.org

Masahiro Yamada <masahiroy@kernel.org> writes:

> On Fri, Oct 30, 2020 at 12:52 AM Boris Kolpackov
> <boris@codesynthesis.com> wrote:
> >
> > - Add missing includes.
> > - Remove no longer necessary includes.
> > - Separate non-portable header includes for easier porting.
> 
> I think the definition of "non-portable"
> depends on how far we expand the supported system.
> 
> I guess you want to segregate <unistd.h> and <sys/mmap.h>
> because you do not have them on Windows, correct?

Correct. I have a set of patches that make kconfig portable to
Windows. I assume there is no interest in these patches here so
I will be maintaining them out of tree (but let me know if my
assumption is wrong and I will happily submit them). Splitting
the header inclusions into two blocks make these patches a bit
cleaner and more resilient to changes.

Let me know if you would like me to change the patch to (1)
clarify the non-portable part or (2) get rid of the split.