From: Boris Kolpackov <boris@codesynthesis.com>
To: Masahiro Yamada <masahiroy@kernel.org>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kconfig: split menu.c out of parser.y
Date: Thu, 15 Apr 2021 12:54:22 +0200 [thread overview]
Message-ID: <boris.20210415125211@codesynthesis.com> (raw)
In-Reply-To: <20210413150817.110282-1-masahiroy@kernel.org>
Masahiro Yamada <masahiroy@kernel.org> writes:
> --- /dev/null
> +++ b/scripts/kconfig/internal.h
> @@ -0,0 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef INTERNAL_H
> +#define INTERNAL_H
> +
> +struct menu;
> +
> +extern struct menu *current_menu, *current_entry;
> +
> +#endif /* INTERNAL_H */
Maybe call it menu.h instead of internal.h? Unless you have plans
to put other "internal" stuff in there.
> --- a/scripts/kconfig/parser.y
> +++ b/scripts/kconfig/parser.y
> @@ -28,7 +29,7 @@ static bool zconf_endtoken(const char *tokenname,
>
> struct symbol *symbol_hash[SYMBOL_HASHSIZE];
>
> -static struct menu *current_menu, *current_entry;
> +struct menu *current_menu, *current_entry;
Why not put these in menu.c?
next prev parent reply other threads:[~2021-04-15 10:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 15:08 [PATCH] kconfig: split menu.c out of parser.y Masahiro Yamada
2021-04-15 10:54 ` Boris Kolpackov [this message]
2021-04-15 12:07 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=boris.20210415125211@codesynthesis.com \
--to=boris@codesynthesis.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.