All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Kolpackov <boris@codesynthesis.com>
To: Richard Weinberger <richard@nod.at>
Cc: masahiroy@kernel.org, linux-kernel@vger.kernel.org,
	linux-kbuild@vger.kernel.org
Subject: Re: [PATCH 2/2] kconfig: Deny command substitution in string values
Date: Wed, 22 Sep 2021 09:17:44 +0200	[thread overview]
Message-ID: <boris.20210922090732@codesynthesis.com> (raw)
In-Reply-To: <20210920213957.1064-2-richard@nod.at>

Richard Weinberger <richard@nod.at> writes:

> The post processed .config file will get included in shell
> and makefiles.

That depends on who you ask: a number of projects other than the
Linux kernel use kconfig for configuration and some of them do
neither of those. I also don't believe the Linux kernel sources
.config in shell (but I may be wrong).


> So make sure that a string does not contain
> symbols that allow command substitution.
> If such a malformed string is found, return empty string
> and report it.

So effectively it's now impossible to include ` or $ in kconfig
string values. Seems like a major, backwards-incompatible
restriction.

I think if this is really desired, then it should be re-done with
escaping (similar to ") rather than outright banning inconvenient 
characters.

  reply	other threads:[~2021-09-22  7:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-20 21:39 [PATCH 1/2] kconfig: Refactor sym_escape_string_value Richard Weinberger
2021-09-20 21:39 ` [PATCH 2/2] kconfig: Deny command substitution in string values Richard Weinberger
2021-09-22  7:17   ` Boris Kolpackov [this message]
2021-09-22  7:27     ` Richard Weinberger
2021-09-22 15:18       ` Boris Kolpackov
2021-09-22 16:17         ` Richard Weinberger
2021-09-25  8:58           ` Masahiro Yamada
2021-09-27 14:34           ` Boris Kolpackov
2021-09-27 12:36 ` [PATCH 1/2] kconfig: Refactor sym_escape_string_value Masahiro Yamada
2021-10-05 15:42   ` Masahiro Yamada
2021-10-07  6:45     ` Richard Weinberger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=boris.20210922090732@codesynthesis.com \
    --to=boris@codesynthesis.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masahiroy@kernel.org \
    --cc=richard@nod.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.