From: bugzilla@dpdk.org
To: dev@dpdk.org
Subject: [Bug 1003] unbalanced braces in header files for extern C declarations causing C++ compilation errors
Date: Mon, 02 May 2022 18:12:05 +0000 [thread overview]
Message-ID: <bug-1003-3@http.bugs.dpdk.org/> (raw)
https://bugs.dpdk.org/show_bug.cgi?id=1003
Bug ID: 1003
Summary: unbalanced braces in header files for extern C
declarations causing C++ compilation errors
Product: DPDK
Version: unspecified
Hardware: All
OS: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: ethdev
Assignee: dev@dpdk.org
Reporter: swasson@microsoft.com
Target Milestone: ---
This was introduced in DPDK 20.11.5. 20.11.4 did not have these issues:
There are a few header files that have multiple extern C declarations, and some
of them have unbalanced braces. This causes C++ compiler errors.
To find them all:
$ find . -name '*.h'|xargs grep 'extern "C' > foo
$ find . -name '*.h'|xargs grep 'extern "C'|uniq > bar
$ diff foo bar
102d101
< ./lib/librte_eventdev/rte_eventdev_pmd.h:extern "C" {
105d103
< ./lib/librte_eventdev/rte_eventdev_pmd_pci.h:extern "C" {
110d107
< ./lib/librte_eventdev/rte_eventdev_pmd_vdev.h:extern "C" {
153d149
< ./lib/librte_ethdev/rte_ethdev_driver.h:extern "C" {
rte_eventdev_pmd.h merely has two nested extern C blocks.
rte_eventdev_pmd_pci.h has two nested extern C blocks, but only one closing
brace at the bottom of the file.
The same is true for rte_ethdev_driver.h and rte_eventdev_pmd_vdev.h.
The latter three cause compilation errors when included from C++ code.
--
You are receiving this mail because:
You are the assignee for the bug.
reply other threads:[~2022-05-02 18:12 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-1003-3@http.bugs.dpdk.org/ \
--to=bugzilla@dpdk.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.