From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 101442] Piglit shaders@ssa@fs-if-def-else-break fails with sb but passes with R600_DEBUG=nosb
Date: Sat, 27 Jan 2018 21:00:57 +0000 [thread overview]
Message-ID: <bug-101442-502-PW0BDRM9K9@http.bugs.freedesktop.org/> (raw)
In-Reply-To: <bug-101442-502@http.bugs.freedesktop.org/>
[-- Attachment #1.1: Type: text/plain, Size: 725 bytes --]
https://bugs.freedesktop.org/show_bug.cgi?id=101442
--- Comment #5 from Gert Wollny <gw.fossdev@gmail.com> ---
With a bit more digging I found out that the sb optimizer simply drops the ELSE
if no ALU instructions are found in the else branch, i.e.
while(cond1)
if (cond2) {
a = b + c;
} else {
break;
}
}
becomes
while(cond1)
if (cond2) {
a = b + c;
break;
}
}
after the first sb/dce_cleanup pass, and this is obviously wrong. With the
break in the if path this is not a problem. I'll attach two piglits that
illustrate the behaviour.
--
You are receiving this mail because:
You are the assignee for the bug.
[-- Attachment #1.2: Type: text/html, Size: 1596 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-01-27 21:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-15 9:07 [Bug 101442] Piglit shaders@ssa@fs-if-def-else-break fails with sb but passes with R600_DEBUG=nosb bugzilla-daemon
2017-06-15 9:19 ` bugzilla-daemon
2017-08-18 14:05 ` bugzilla-daemon
2017-11-26 22:58 ` bugzilla-daemon
2018-01-27 10:49 ` bugzilla-daemon
2018-01-27 21:00 ` bugzilla-daemon [this message]
2018-01-27 21:03 ` bugzilla-daemon
2018-01-27 21:05 ` bugzilla-daemon
2018-03-28 16:55 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-101442-502-PW0BDRM9K9@http.bugs.freedesktop.org/ \
--to=bugzilla-daemon@freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.