All of lore.kernel.org
 help / color / mirror / Atom feed
From: bugzilla at busybox.net <bugzilla@busybox.net>
To: buildroot@busybox.net
Subject: [Buildroot] [Bug 10151] toolchain eclipse register : fails with a custom BR2_HOST_DIR
Date: Fri, 04 Aug 2017 16:43:42 +0000	[thread overview]
Message-ID: <bug-10151-163-xmEwKPN8tl@https.bugs.busybox.net/> (raw)
In-Reply-To: <bug-10151-163@https.bugs.busybox.net/>

https://bugs.busybox.net/show_bug.cgi?id=10151

Arnout Vandecappelle <arnout@mind.be> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Assignee|unassigned at buildroot.uclibc |arnout at mind.be
                   |.org                        |
             Status|NEW                         |ASSIGNED

--- Comment #4 from Arnout Vandecappelle <arnout@mind.be> ---
(In reply to Thomas Petazzoni from comment #2)
> I'm not really happy to add this host symlink just for the sake
> of making the eclipse-register-toolchain script work.

It's more that scripts in general (e.g. post-build scripts) may assume that
$(O)/host exists, and it just simplifies life in general if you can rely on it
being there. A bit like the staging symlink.

Note that things *will* break dramatically if you change BR2_HOST_DIR and try
to rebuild. So there can be no argument of "the symlink could dangle".

> Instead, we should pass $(HOST_DIR) as argument to eclipse-register-toolchain.

HOST_DIR is already exported, no need to add an argument.

However, if you look at the script, you'll see that it just checks that
${project_directory}/host exists, but this directory is *not* encoded in the
eclipse toolchains file. Since there is apparently no way to pass BR2_HOST_DIR
to eclipse, I guess a non-default BR2_HOST_DIR can't be supported without
changing both the eclipse plugin and the toolchains file. That, in turn,
requires a synchronised update, and old Buildroots won't run with the new
eclipse plugin and vice versa...

In short: I propose to add the symlink :-)
http://patchwork.ozlabs.org/patch/797910/

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2017-08-04 16:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-03  9:25 [Buildroot] [Bug 10151] New: toolchain eclipse register : fails with a custom BR2_HOST_DIR bugzilla at busybox.net
2017-08-03 21:29 ` [Buildroot] [Bug 10151] " bugzilla at busybox.net
2017-08-04  7:03 ` bugzilla at busybox.net
2017-08-04  7:38 ` bugzilla at busybox.net
2017-08-04 16:43 ` bugzilla at busybox.net [this message]
2018-04-01 10:16 ` bugzilla at busybox.net

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-10151-163-xmEwKPN8tl@https.bugs.busybox.net/ \
    --to=bugzilla@busybox.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.