From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 101651] [radeonsi][hawaii] Borderlands 2 rendering issues with recent mesa/llvm Date: Thu, 29 Jun 2017 17:58:09 +0000 Message-ID: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1269815145==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id CA1556E6CA for ; Thu, 29 Jun 2017 17:58:09 +0000 (UTC) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1269815145== Content-Type: multipart/alternative; boundary="14987590890.09BAEA3.2195"; charset="UTF-8" --14987590890.09BAEA3.2195 Date: Thu, 29 Jun 2017 17:58:09 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D101651 Bug ID: 101651 Summary: [radeonsi][hawaii] Borderlands 2 rendering issues with recent mesa/llvm Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Priority: medium Component: Drivers/Gallium/radeonsi Assignee: dri-devel@lists.freedesktop.org Reporter: ptpzz@yandex.ru QA Contact: dri-devel@lists.freedesktop.org Created attachment 132354 --> https://bugs.freedesktop.org/attachment.cgi?id=3D132354&action=3Dedit screenshot (wrong rendering) AFAICS it's related to the VCCZ bug. There is a workaround for SI/CIK in the AMDGPU LLVM backend (SIInsertWaitcnts.cpp) but it doesn't handle this case. The attached patch fixes it for me by relaxing the workaround condition, but probably it can be improved if there is a detailed info on that bug. OTOH I guess it won't have a noticeable effect on performance anyway, so maybe it's safer to use the patch as is. The issue is reproducible with the reduced OpenCL test in the attachment: $ make // run on cpu - reference result $ ./testcpu 117 // OpenCL/gpu - wrong result $ LD_PRELOAD=3D/opt/llvm64_master/lib/libLLVM-5.0svn.so ./testgpu 99 // OpenCL/gpu + patch - correct result $ LD_PRELOAD=3D/opt/llvm64_patched/lib/libLLVM-5.0svn.so ./testgpu 117 --=20 You are receiving this mail because: You are the assignee for the bug.= --14987590890.09BAEA3.2195 Date: Thu, 29 Jun 2017 17:58:09 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated
Bug ID 101651
Summary [radeonsi][hawaii] Borderlands 2 rendering issues with recent= mesa/llvm
Product Mesa
Version git
Hardware Other
OS All
Status NEW
Severity normal
Priority medium
Component Drivers/Gallium/radeonsi
Assignee dri-devel@lists.freedesktop.org
Reporter ptpzz@yandex.ru
QA Contact dri-devel@lists.freedesktop.org 

Created attachment =
132354 [details]
screenshot (wrong rendering)

AFAICS it's related to the VCCZ bug. There is a workaround for SI/CIK in the
AMDGPU LLVM backend (SIInsertWaitcnts.cpp) but it doesn't handle this case.

The attached patch fixes it for me by relaxing the workaround condition, but
probably it can be improved if there is a detailed info on that bug. OTOH I
guess it won't have a noticeable effect on performance anyway, so maybe it's
safer to use the patch as is.

The issue is reproducible with the reduced OpenCL test in the attachment:

  $ make

  // run on cpu - reference result

  $ ./testcpu
  117

  // OpenCL/gpu - wrong result

  $ LD_PRELOAD=3D/opt/llvm64_master/lib/libLLVM-5.0svn.so ./testgpu
  99

  // OpenCL/gpu + patch - correct result

  $ LD_PRELOAD=3D/opt/llvm64_patched/lib/libLLVM-5.0svn.so ./testgpu
  117

You are receiving this mail because:
  • You are the assignee for the bug.
= --14987590890.09BAEA3.2195-- --===============1269815145== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1269815145==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 101651] [radeonsi][hawaii] Borderlands 2 rendering issues with recent mesa/llvm Date: Thu, 29 Jun 2017 17:58:56 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0161092833==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 4AA386E6D2 for ; Thu, 29 Jun 2017 17:58:56 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0161092833== Content-Type: multipart/alternative; boundary="14987591360.bDeA.2601"; charset="UTF-8" --14987591360.bDeA.2601 Date: Thu, 29 Jun 2017 17:58:56 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D101651 --- Comment #1 from Vadim Girlin --- Created attachment 132355 --> https://bugs.freedesktop.org/attachment.cgi?id=3D132355&action=3Dedit screenshot (correct rendering) --=20 You are receiving this mail because: You are the assignee for the bug.= --14987591360.bDeA.2601 Date: Thu, 29 Jun 2017 17:58:56 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 1 on bug 10165= 1 from Vadim Girlin 
Created attachmen=
t 132355 [details]
screenshot (correct rendering)

You are receiving this mail because:
  • You are the assignee for the bug.
= --14987591360.bDeA.2601-- --===============0161092833== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0161092833==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 101651] [radeonsi][hawaii] Borderlands 2 rendering issues with recent mesa/llvm Date: Thu, 29 Jun 2017 17:59:36 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1911796959==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id 78CFB6E6D3 for ; Thu, 29 Jun 2017 17:59:36 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1911796959== Content-Type: multipart/alternative; boundary="14987591760.6D06.2480"; charset="UTF-8" --14987591760.6D06.2480 Date: Thu, 29 Jun 2017 17:59:36 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D101651 --- Comment #2 from Vadim Girlin --- Created attachment 132356 --> https://bugs.freedesktop.org/attachment.cgi?id=3D132356&action=3Dedit llvm patch --=20 You are receiving this mail because: You are the assignee for the bug.= --14987591760.6D06.2480 Date: Thu, 29 Jun 2017 17:59:36 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

You are receiving this mail because:
  • You are the assignee for the bug.
= --14987591760.6D06.2480-- --===============1911796959== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1911796959==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 101651] [radeonsi][hawaii] Borderlands 2 rendering issues with recent mesa/llvm Date: Thu, 29 Jun 2017 18:00:14 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1536960931==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 193086E6D4 for ; Thu, 29 Jun 2017 18:00:14 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1536960931== Content-Type: multipart/alternative; boundary="14987592140.0A58b71.2972"; charset="UTF-8" --14987592140.0A58b71.2972 Date: Thu, 29 Jun 2017 18:00:14 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D101651 --- Comment #3 from Vadim Girlin --- Created attachment 132357 --> https://bugs.freedesktop.org/attachment.cgi?id=3D132357&action=3Dedit reduced test --=20 You are receiving this mail because: You are the assignee for the bug.= --14987592140.0A58b71.2972 Date: Thu, 29 Jun 2017 18:00:14 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

You are receiving this mail because:
  • You are the assignee for the bug.
= --14987592140.0A58b71.2972-- --===============1536960931== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1536960931==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 101651] [radeonsi][hawaii] Borderlands 2 rendering issues with recent mesa/llvm Date: Sun, 02 Jul 2017 11:14:41 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1211359154==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id E4AC96E0C9 for ; Sun, 2 Jul 2017 11:14:40 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1211359154== Content-Type: multipart/alternative; boundary="14989940801.1B6cC510.23986"; charset="UTF-8" --14989940801.1B6cC510.23986 Date: Sun, 2 Jul 2017 11:14:40 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D101651 --- Comment #4 from Gregor M=C3=BCnch --- Can confirm the bug on SI (Radeon HD 7970) and Borderlands: The Pre-Sequel LLVM 5.0.0svn_r306967 --=20 You are receiving this mail because: You are the assignee for the bug.= --14989940801.1B6cC510.23986 Date: Sun, 2 Jul 2017 11:14:40 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated

Commen= t # 4 on bug 10165= 1 from Gregor M=C3=BCnch 
Can confirm the bug on SI (Radeon HD 7970) and Borderlands: Th=
e Pre-Sequel
LLVM 5.0.0svn_r306967

You are receiving this mail because:
  • You are the assignee for the bug.
= --14989940801.1B6cC510.23986-- --===============1211359154== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1211359154==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 101651] [radeonsi][hawaii] Borderlands 2 rendering issues with recent mesa/llvm Date: Tue, 01 May 2018 15:58:21 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1785751825==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [131.252.210.165]) by gabe.freedesktop.org (Postfix) with ESMTP id AE9146E424 for ; Tue, 1 May 2018 15:58:21 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1785751825== Content-Type: multipart/alternative; boundary="15251903011.BBccF41e7.26588" Content-Transfer-Encoding: 7bit --15251903011.BBccF41e7.26588 Date: Tue, 1 May 2018 15:58:21 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D101651 Gregor M=C3=BCnch changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO --- Comment #5 from Gregor M=C3=BCnch --- Looks good now for me. Still an issue for you? --=20 You are receiving this mail because: You are the assignee for the bug.= --15251903011.BBccF41e7.26588 Date: Tue, 1 May 2018 15:58:21 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated Gregor M=C3=BCnch changed bug 10165= 1
What Removed Added
Status NEW NEEDINFO

Commen= t # 5 on bug 10165= 1 from Gregor M=C3=BCnch 
Looks good now for me.
Still an issue for you?

You are receiving this mail because:
  • You are the assignee for the bug.
= --15251903011.BBccF41e7.26588-- --===============1785751825== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1785751825==-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 101651] [radeonsi][hawaii] Borderlands 2 rendering issues with recent mesa/llvm Date: Thu, 02 Aug 2018 00:56:47 +0000 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0478203901==" Return-path: Received: from culpepper.freedesktop.org (culpepper.freedesktop.org [IPv6:2610:10:20:722:a800:ff:fe98:4b55]) by gabe.freedesktop.org (Postfix) with ESMTP id 35E206E4EA for ; Thu, 2 Aug 2018 00:56:47 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0478203901== Content-Type: multipart/alternative; boundary="15331714070.9CeDA3eD.31981" Content-Transfer-Encoding: 7bit --15331714070.9CeDA3eD.31981 Date: Thu, 2 Aug 2018 00:56:47 +0000 MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated https://bugs.freedesktop.org/show_bug.cgi?id=3D101651 Timothy Arceri changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEEDINFO |RESOLVED --=20 You are receiving this mail because: You are the assignee for the bug.= --15331714070.9CeDA3eD.31981 Date: Thu, 2 Aug 2018 00:56:47 +0000 MIME-Version: 1.0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://bugs.freedesktop.org/ Auto-Submitted: auto-generated Timothy Arceri changed bug 10165= 1
What Removed Added
Resolution --- FIXED
Status NEEDINFO RESOLVED

You are receiving this mail because:
  • You are the assignee for the bug.
= --15331714070.9CeDA3eD.31981-- --===============0478203901== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0478203901==--