| Bug ID | 102014 |
|---|---|
| Summary | Mesa git build broken by commit bc7f41e11d325280db12e7b944450= 1357bc13922 |
| Product | Mesa |
| Version | git |
| Hardware | Other |
| OS | All |
| Status | NEW |
| Severity | normal |
| Priority | medium |
| Component | Drivers/Gallium/radeonsi |
| Assignee | dri-devel@lists.freedesktop.org |
| Reporter | marko.skender@protonmail.com |
| QA Contact | dri-devel@lists.freedesktop.org |
Hello, Current git build is seemingly broken by: [ 511s] pipe_radeonsi.c: In function 'create_screen': [ 511s] pipe_radeonsi.c:15:34: error: 'flags' undeclared (first use in this function); did you mean 'fabs'? [ 511s] rw =3D amdgpu_winsys_create(fd, flags, radeonsi_screen_create); [ 511s] ^~~~~ [ 511s] fabs [ 511s] pipe_radeonsi.c:15:34: note: each undeclared identifier is reported only once for each function it appears in [ 511s] make[4]: *** [Makefile:996: pipe_radeonsi.lo] Error 1 [ 511s] make[4]: *** Waiting for unfinished jobs.... [ 511s] pipe_r600.c: In function 'create_screen': [ 511s] pipe_r600.c:12:38: error: 'flags' undeclared (first use in this function); did you mean 'fabs'? [ 511s] rw =3D radeon_drm_winsys_create(fd, flags, r600_screen_create); [ 511s] ^~~~~ [ 511s] fabs [ 511s] pipe_r600.c:12:38: note: each undeclared identifier is reported on= ly once for each function it appears in [ 511s] pipe_r300.c: In function 'create_screen': [ 511s] pipe_r300.c:12:39: error: 'flags' undeclared (first use in this function); did you mean 'fabs'? [ 511s] sws =3D radeon_drm_winsys_create(fd, flags, r300_screen_create= ); [ 511s] ^~~~~ [ 511s] fabs Regards, Marko
Created attachment 133196<= /a> [details] [review] Patch #1 to fix build
Created attachment 133197<= /a> [details] [review] Patch #2 to fix build
Created attachment 133198<= /a> [details] [review] Patch #3 to fix build
Thanks for the report Marko. Can you please squash these three patches (analogous to the offending commi= t) and send the patch to the list - see https://www.mesa3= d.org/submittingpatches.html for details. One small correction - one should get the flags from config->flags. Please include the following in the commit message: Cc: Nicolai H=C3=A4hnle <= nicolai.haehnle@amd.com> Fixes: bc7f41e11d3 ("gallium: add pipe_screen_config to screen_create functions")
*sigh* This has not been a good week for me. Please see http= s://patchwork.freedesktop.org/patch/170007/
| What | Removed | Added |
|---|---|---|
| Keywords | bisected, regression |
| What | Removed | Added |
|---|---|---|
| CC | pedretti.fabio@gmail.com |
*** Bug 102016 has been marked as a du= plicate of this bug. ***
| What | Removed | Added |
|---|---|---|
| Attachment #133196 is obsolete | 1 | |
| Attachment #133197 is obsolete | 1 | |
| Attachment #133198 is obsolete | 1 |
Created attachm= ent 133223 [details] [review]= Fixes build for current Mesa-git Hi guys, I've generated a single patch which currently builds successfully on commit= =20=20=20=20 d5ba75f8881f0869dc16f71f7395514c0a35b6e2 Ragards, Marko
Also see this thread =3D there are more fixes needed to avoid = issues after the build is fixed. https://lists.freedesktop.org/archives/mesa-dev/2017-August/165195= .html
| What | Removed | Added |
|---|---|---|
| Resolution | --- | FIXED |
| Status | NEW | RESOLVED |
The build should be fixed again with commit 33f7d71d5358337f08ce0bb94f5e915bda77748c, so closing this bug. (Note additi= onal patches are on their way which are required if you build only OpenCL.) FYI, there are also segfaults, which should be fixed by this series: https://patchwo= rk.freedesktop.org/series/28311/